Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1566553002: Replace CPDF_SortObjNumArray with a std::set. (Closed)

Created:
4 years, 11 months ago by Lei Zhang
Modified:
4 years, 11 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit, rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -50 lines) Patch
M core/include/fpdfapi/fpdf_parser.h View 1 1 chunk +0 lines, -13 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 1 8 chunks +9 lines, -37 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Lei Zhang
4 years, 11 months ago (2016-01-06 00:32:15 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/1566553002/diff/1/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp File core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp (right): https://codereview.chromium.org/1566553002/diff/1/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp#newcode2820 core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp:2820: std::set<FX_DWORD> m_objnum_set; nit: the naming convention for a ...
4 years, 11 months ago (2016-01-06 00:49:56 UTC) #3
Lei Zhang
https://codereview.chromium.org/1566553002/diff/1/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp File core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp (right): https://codereview.chromium.org/1566553002/diff/1/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp#newcode2820 core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp:2820: std::set<FX_DWORD> m_objnum_set; On 2016/01/06 00:49:56, Tom Sepez wrote: > ...
4 years, 11 months ago (2016-01-06 00:52:26 UTC) #4
Lei Zhang
4 years, 11 months ago (2016-01-06 00:55:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
6caae4d3c6815c5a1e12340734412a3bc7548652 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698