Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Issue 1561723002: Revert of Aura Android: ShowBrowserSignin is not defined for Android, use NOTIMPLEMENTED for now (Closed)

Created:
4 years, 11 months ago by bshe
Modified:
4 years, 11 months ago
Reviewers:
Finnur, mfomitchev
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Aura Android: ShowBrowserSignin is not defined for Android, use NOTIMPLEMENTED for now (patchset #2 id:20001 of https://codereview.chromium.org/1465953003/ ) Reason for revert: We dont need to support Aura Android at current stage. Revert related code. Original issue's description: > Aura Android: ShowBrowserSignin is not defined for Android, use NOTIMPLEMENTED for now > > BUG=557285 > > Committed: https://crrev.com/b21a4e021fd5e71ecd0a55861f3500f007507986 > Cr-Commit-Position: refs/heads/master@{#361133} TBR=mfomitchev@chromium.org,finnur@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=557285

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
bshe
Created Revert of Aura Android: ShowBrowserSignin is not defined for Android, use NOTIMPLEMENTED for now
4 years, 11 months ago (2016-01-05 19:38:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1561723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1561723002/1
4 years, 11 months ago (2016-01-05 19:40:49 UTC) #2
commit-bot: I haz the power
Failed to apply patch for chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc: While running git apply --index -3 -p1; error: patch ...
4 years, 11 months ago (2016-01-05 19:43:31 UTC) #4
bshe
4 years, 11 months ago (2016-01-05 19:53:19 UTC) #6
close without submit.

The change is not in TOT anymore. So we dont need to revert.

Powered by Google App Engine
This is Rietveld 408576698