Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Side by Side Diff: chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc

Issue 1561723002: Revert of Aura Android: ShowBrowserSignin is not defined for Android, use NOTIMPLEMENTED for now (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/extensions/extension_installed_bubble_view.h" 5 #include "chrome/browser/ui/views/extensions/extension_installed_bubble_view.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <string> 8 #include <string>
9 9
10 #include "base/i18n/rtl.h" 10 #include "base/i18n/rtl.h"
(...skipping 268 matching lines...) Expand 10 before | Expand all | Expand 10 after
279 void InstalledBubbleContent::ButtonPressed(views::Button* sender, 279 void InstalledBubbleContent::ButtonPressed(views::Button* sender,
280 const ui::Event& event) { 280 const ui::Event& event) {
281 DCHECK_EQ(sender, close_button_); 281 DCHECK_EQ(sender, close_button_);
282 GetWidget()->Close(); 282 GetWidget()->Close();
283 } 283 }
284 284
285 void InstalledBubbleContent::LinkClicked(views::Link* source, int event_flags) { 285 void InstalledBubbleContent::LinkClicked(views::Link* source, int event_flags) {
286 GetWidget()->Close(); 286 GetWidget()->Close();
287 287
288 if (source == sign_in_link_) { 288 if (source == sign_in_link_) {
289 #if defined(OS_ANDROID)
290 // TODO(bshe): Figure out what to do on Android platform. See
291 // crbug.com/559340.
292 NOTIMPLEMENTED();
293 #else
294 chrome::ShowBrowserSignin( 289 chrome::ShowBrowserSignin(
295 browser_, signin_metrics::SOURCE_EXTENSION_INSTALL_BUBBLE); 290 browser_, signin_metrics::SOURCE_EXTENSION_INSTALL_BUBBLE);
296 #endif
297 return; 291 return;
298 } 292 }
299 293
300 DCHECK_EQ(manage_shortcut_, source); 294 DCHECK_EQ(manage_shortcut_, source);
301 295
302 std::string configure_url = chrome::kChromeUIExtensionsURL; 296 std::string configure_url = chrome::kChromeUIExtensionsURL;
303 configure_url += chrome::kExtensionConfigureCommandsSubPage; 297 configure_url += chrome::kExtensionConfigureCommandsSubPage;
304 chrome::NavigateParams params(chrome::GetSingletonTabNavigateParams( 298 chrome::NavigateParams params(chrome::GetSingletonTabNavigateParams(
305 browser_, GURL(configure_url))); 299 browser_, GURL(configure_url)));
306 chrome::Navigate(&params); 300 chrome::Navigate(&params);
(...skipping 254 matching lines...) Expand 10 before | Expand all | Expand 10 after
561 if (bubble_->extension() && bubble_->type() == bubble_->PAGE_ACTION && 555 if (bubble_->extension() && bubble_->type() == bubble_->PAGE_ACTION &&
562 !extensions::FeatureSwitch::extension_action_redesign()->IsEnabled()) { 556 !extensions::FeatureSwitch::extension_action_redesign()->IsEnabled()) {
563 BrowserView* browser_view = 557 BrowserView* browser_view =
564 BrowserView::GetBrowserViewForBrowser(bubble_->browser()); 558 BrowserView::GetBrowserViewForBrowser(bubble_->browser());
565 browser_view->GetLocationBarView()->SetPreviewEnabledPageAction( 559 browser_view->GetLocationBarView()->SetPreviewEnabledPageAction(
566 extensions::ExtensionActionManager::Get(bubble_->browser()->profile()) 560 extensions::ExtensionActionManager::Get(bubble_->browser()->profile())
567 ->GetPageAction(*bubble_->extension()), 561 ->GetPageAction(*bubble_->extension()),
568 false); // preview_enabled 562 false); // preview_enabled
569 } 563 }
570 } 564 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698