Fix bug where scroll position was being restored after navigation completes

Correctly update frame load type after same-doc (history) navigation completion

For same document navigation the |FrameLoader::m_loadType| is set temporarily which means it gets
reset once load completes. This ensures we do not incorrectly attempt to restore scroll position
on content/frame size change once navigation is finished.

BUG=574487
TEST=fast/loader/scroll-restore-should-happen-during-load.html

Committed: https://crrev.com/91e6e97ccdc0d6cdd4e3543102ccc0f90a6da004
Cr-Commit-Position: refs/heads/master@{#369169}

[majidvp, 2016-01-05 20:25:21]

Description was changed from

==========
Fix bug where scroll position was being restored after navigation completes


BUG=574487
==========

to

==========
Ensure scroll position is not restored after navigation completes

Set |FrameLoader::m_loadType| to FrameLoadTypeStandard for same document loads
after load is complete.
This ensures that scroll position is not restored once load is complete.


BUG=574487
TEST=fast/loader/scroll-restore-should-happen-during-load.html
==========

[majidvp, 2016-01-05 20:26:52]

majidvp@chromium.org changed reviewers:
+ japhet@chromium.org

[Nate Chapin, 2016-01-05 21:58:32]

How does this work if the original navigation was, e.g., a reload? Won't this
mean that if a same-document navigation is triggered by an inline script, the
load type will be set back to standard, and therefore any subsequent subresource
loads will be treated as part of a standard load instead of as part of a reload
(and therefore eligible for revalidation)?

[majidvp, 2016-01-08 15:19:21]

On 2016/01/05 21:58:32, Nate Chapin wrote:
> How does this work if the original navigation was, e.g., a reload? Won't this
> mean that if a same-document navigation is triggered by an inline script, the
> load type will be set back to standard, and therefore any subsequent
subresource
> loads will be treated as part of a standard load instead of as part of a
reload
> (and therefore eligible for revalidation)?

Good catch! I believe that is correct and it is a problem that may occur today
as well
because we would override the reload navigation with the load type for the same
doc
navigation anyways.

I have a potential fix here which is to revert the loadType once same doc load
is done.

[Nate Chapin, 2016-01-13 00:54:37]

If it were possible to get to the point that we didn't have to set
FrameLoader::m_loadType for same-document navigations, that would be ideal. But
this is good in the meantime :) LGTM

[majidvp, 2016-01-13 13:39:47]

Description was changed from

==========
Ensure scroll position is not restored after navigation completes

Set |FrameLoader::m_loadType| to FrameLoadTypeStandard for same document loads
after load is complete.
This ensures that scroll position is not restored once load is complete.


BUG=574487
TEST=fast/loader/scroll-restore-should-happen-during-load.html
==========

to

==========
Correctly update frame load type after same-doc (history) navigation completion

For same document navigation the |FrameLoader::m_loadType| is set temporarily
which means it gets
reset once load completes. This ensures we do not incorrectly attempt to restore
scroll position
on content/frame size change once navigation is finished.

BUG=574487
TEST=fast/loader/scroll-restore-should-happen-during-load.html
==========

[majidvp, 2016-01-13 13:40:32]

The CQ bit was checked by majidvp@chromium.org

[commit-bot: I haz the power, 2016-01-13 13:40:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1561573004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1561573004/40001

[commit-bot: I haz the power, 2016-01-13 15:05:56]

Description was changed from

==========
Correctly update frame load type after same-doc (history) navigation completion

For same document navigation the |FrameLoader::m_loadType| is set temporarily
which means it gets
reset once load completes. This ensures we do not incorrectly attempt to restore
scroll position
on content/frame size change once navigation is finished.

BUG=574487
TEST=fast/loader/scroll-restore-should-happen-during-load.html
==========

to

==========
Correctly update frame load type after same-doc (history) navigation completion

For same document navigation the |FrameLoader::m_loadType| is set temporarily
which means it gets
reset once load completes. This ensures we do not incorrectly attempt to restore
scroll position
on content/frame size change once navigation is finished.

BUG=574487
TEST=fast/loader/scroll-restore-should-happen-during-load.html
==========

[commit-bot: I haz the power, 2016-01-13 15:05:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-13 15:07:32]

Description was changed from

==========
Correctly update frame load type after same-doc (history) navigation completion

For same document navigation the |FrameLoader::m_loadType| is set temporarily
which means it gets
reset once load completes. This ensures we do not incorrectly attempt to restore
scroll position
on content/frame size change once navigation is finished.

BUG=574487
TEST=fast/loader/scroll-restore-should-happen-during-load.html
==========

to

==========
Correctly update frame load type after same-doc (history) navigation completion

For same document navigation the |FrameLoader::m_loadType| is set temporarily
which means it gets
reset once load completes. This ensures we do not incorrectly attempt to restore
scroll position
on content/frame size change once navigation is finished.

BUG=574487
TEST=fast/loader/scroll-restore-should-happen-during-load.html

Committed: https://crrev.com/91e6e97ccdc0d6cdd4e3543102ccc0f90a6da004
Cr-Commit-Position: refs/heads/master@{#369169}
==========

[commit-bot: I haz the power, 2016-01-13 15:07:32]

Patchset 3 (id:??) landed as
https://crrev.com/91e6e97ccdc0d6cdd4e3543102ccc0f90a6da004
Cr-Commit-Position: refs/heads/master@{#369169}