third_party/WebKit/Source/core/loader/FrameLoader.h - Issue 1561573004: Fix bug where scroll position was being restored after navigation completes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/FrameLoader.h

Issue 1561573004: Fix bug where scroll position was being restored after navigation completes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Restore to previous type Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/loader/scroll-restore-should-happen-during-load-expected.txt ('k') | third_party/WebKit/Source/core/loader/FrameLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/loader/FrameLoader.h

diff --git a/third_party/WebKit/Source/core/loader/FrameLoader.h b/third_party/WebKit/Source/core/loader/FrameLoader.h

index b67c737a2779b875ac995c91fe41790a73524988..1f9ad89e961c9951c8be1020a1f7988d8cb86b16 100644

--- a/third_party/WebKit/Source/core/loader/FrameLoader.h

+++ b/third_party/WebKit/Source/core/loader/FrameLoader.h

@@ -211,7 +211,7 @@ private:

};

void setHistoryItemStateForCommit(HistoryCommitType, HistoryNavigationType);

- void loadInSameDocument(const KURL&, PassRefPtr<SerializedScriptValue> stateObject, FrameLoadType, ClientRedirectPolicy);

+ void loadInSameDocument(const KURL&, PassRefPtr<SerializedScriptValue> stateObject, FrameLoadType, HistoryLoadType, ClientRedirectPolicy);

void scheduleCheckCompleted();