Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Unified Diff: net/spdy/spdy_test_utils.cc

Issue 1561203003: Remove SPDY/2 code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/spdy_test_utils.cc
diff --git a/net/spdy/spdy_test_utils.cc b/net/spdy/spdy_test_utils.cc
index bc0dc17f66ad9fb17e88ad5e95001801ebe8b908..3162bd85d09885ef2f31b033ba1d1cf0532acd5f 100644
--- a/net/spdy/spdy_test_utils.cc
+++ b/net/spdy/spdy_test_utils.cc
@@ -92,7 +92,6 @@ void SetFrameFlags(SpdyFrame* frame,
uint8_t flags,
SpdyMajorVersion spdy_version) {
switch (spdy_version) {
- case SPDY2:
case SPDY3:
case HTTP2:
frame->data()[4] = flags;
@@ -106,12 +105,11 @@ void SetFrameLength(SpdyFrame* frame,
size_t length,
SpdyMajorVersion spdy_version) {
switch (spdy_version) {
- case SPDY2:
case SPDY3:
CHECK_EQ(0u, length & ~kLengthMask);
{
int32_t wire_length = base::HostToNet32(length);
- // The length field in SPDY 2 and 3 is a 24-bit (3B) integer starting at
+ // The length field in SPDY 2 is a 24-bit (3B) integer starting at
Ryan Hamilton 2016/01/07 22:09:15 s/2/3/ ?
Bence 2016/01/08 18:58:25 Oops.
// offset 5.
memcpy(frame->data() + 5, reinterpret_cast<char*>(&wire_length) + 1, 3);
}

Powered by Google App Engine
This is Rietveld 408576698