Remove SPDY/2 code.

net/spdy/spdy_protocol_test.cc

Index: net/spdy/spdy_protocol_test.cc
diff --git a/net/spdy/spdy_protocol_test.cc b/net/spdy/spdy_protocol_test.cc
index 6117994aeea3855889ce00a9f52a3310dd9a337b..251c9d8a787c884d7fb0bcc6cfdb4e0a2a9b3249 100644
--- a/net/spdy/spdy_protocol_test.cc
+++ b/net/spdy/spdy_protocol_test.cc
@@ -15,7 +15,6 @@
 namespace {
 
 enum SpdyProtocolTestTypes {
-  SPDY2 = net::SPDY2,
   SPDY3 = net::SPDY3,
 };
 
@@ -34,17 +33,15 @@ class SpdyProtocolTest
   SpdyMajorVersion spdy_version_;
 };
 
-// All tests are run with two different SPDY versions: SPDY/2 and SPDY/3.
 INSTANTIATE_TEST_CASE_P(SpdyProtocolTests,

[Ryan Hamilton, 2016/01/07 22:09:15]

If we're just doing 1 version, do we still want to do a TEST_P?

(Should we test HTTP2 also?)

[Bence, 2016/01/08 18:58:25]

Oops, sorry I didn't catch this.

Turns out |spdy_version_| test class member here was a joke, the
SettingsFlagsAndId methods that this class exercise do not care about the
version.  So no need to test HTTP/2, it's indentical.

What is "opt mode" (in the comment)?  What does this test actually do anyway? 
Does it really test the API or an implementation detail?

[Ryan Hamilton, 2016/01/08 20:53:06]

opt mode == !debug mode. Which is to say, when DCHECK (and friends) are not
enabled.

                         SpdyProtocolTest,
-                        ::testing::Values(SPDY2, SPDY3));
+                        ::testing::Values(SPDY3));
 
 class SpdyProtocolDeathTest : public SpdyProtocolTest {};
 
-// All tests are run with two different SPDY versions: SPDY/2 and SPDY/3.
 INSTANTIATE_TEST_CASE_P(SpdyProtocolDeathTests,
                         SpdyProtocolDeathTest,
-                        ::testing::Values(SPDY2, SPDY3));
+                        ::testing::Values(SPDY3));
 
 TEST_P(SpdyProtocolDeathTest, TestSpdySettingsAndIdOutOfBounds) {
   scoped_ptr<SettingsFlagsAndId> flags_and_id;