Remove SPDY/2 code.

Remove SPDY/2 code.

SPDY/2 code path has been unused for a long time, this CL actually removes it.

Note that there have been two comparisons between an enum SpdyMajorVersion value
and an interger literal: one in SpdyFramer::WriteHeaderBlockToZ(), and one in
spdy_http_utils.cc::SpdyHeadersToHttpResponse().  Changing enum SpdyMajorVersion
member values lead to errors.  However, removing SPDY/2 made these comparisons
mute (they were both |version < SPDY3|), so they are removed instead of fixed.

This CL lands server change 111503966 by alyssar.

BUG=431299, 488484
Committed: https://crrev.com/05808ff4705c00acc1d0a2683a0ed657db4e4abf
Cr-Commit-Position: refs/heads/master@{#368459}

[Bence, 2016-01-07 20:00:00]

bnc@chromium.org changed reviewers:
+ rch@chromium.org

[Bence, 2016-01-07 20:00:00]

Ryan: PTAL.

[Ryan Hamilton, 2016-01-07 22:09:15]

HAPPY HAPPY HAPPY DAY!

https://codereview.chromium.org/1561203003/diff/1/net/http/http_response_info.cc
File net/http/http_response_info.cc (right):

https://codereview.chromium.org/1561203003/diff/1/net/http/http_response_info...
net/http/http_response_info.cc:419: return "";
Can we nuke this old value, or is it persisted somewhere?

https://codereview.chromium.org/1561203003/diff/1/net/http/http_server_proper...
File net/http/http_server_properties.h (right):

https://codereview.chromium.org/1561203003/diff/1/net/http/http_server_proper...
net/http/http_server_properties.h:73: NPN_HTTP_2,  // HTTP/2
nit: this comment seems unnecessary

https://codereview.chromium.org/1561203003/diff/1/net/spdy/spdy_protocol_test.cc
File net/spdy/spdy_protocol_test.cc (right):

https://codereview.chromium.org/1561203003/diff/1/net/spdy/spdy_protocol_test...
net/spdy/spdy_protocol_test.cc:36: INSTANTIATE_TEST_CASE_P(SpdyProtocolTests,
If we're just doing 1 version, do we still want to do a TEST_P?

(Should we test HTTP2 also?)

https://codereview.chromium.org/1561203003/diff/1/net/spdy/spdy_test_utils.cc
File net/spdy/spdy_test_utils.cc (right):

https://codereview.chromium.org/1561203003/diff/1/net/spdy/spdy_test_utils.cc...
net/spdy/spdy_test_utils.cc:112: // The length field in SPDY 2 is a 24-bit (3B)
integer starting at
s/2/3/ ?

[Bence, 2016-01-08 18:58:25]

Ryan: PTAL.  Thanks.

https://codereview.chromium.org/1561203003/diff/1/net/http/http_response_info.cc
File net/http/http_response_info.cc (right):

https://codereview.chromium.org/1561203003/diff/1/net/http/http_response_info...
net/http/http_response_info.cc:419: return "";
On 2016/01/07 22:09:15, Ryan Hamilton wrote:
> Can we nuke this old value, or is it persisted somewhere?

Yes, we can nuke this.  However, in that case, I should probably reword the
comment above the enum:
https://code.google.com/p/chromium/codesearch#chromium/src/net/http/http_resp...

So how about a follow-up CL?

https://codereview.chromium.org/1561203003/diff/1/net/http/http_server_proper...
File net/http/http_server_properties.h (right):

https://codereview.chromium.org/1561203003/diff/1/net/http/http_server_proper...
net/http/http_server_properties.h:73: NPN_HTTP_2,  // HTTP/2
On 2016/01/07 22:09:15, Ryan Hamilton wrote:
> nit: this comment seems unnecessary

That's a way to put it.  :)

Done.

https://codereview.chromium.org/1561203003/diff/1/net/spdy/spdy_protocol_test.cc
File net/spdy/spdy_protocol_test.cc (right):

https://codereview.chromium.org/1561203003/diff/1/net/spdy/spdy_protocol_test...
net/spdy/spdy_protocol_test.cc:36: INSTANTIATE_TEST_CASE_P(SpdyProtocolTests,
On 2016/01/07 22:09:15, Ryan Hamilton wrote:
> If we're just doing 1 version, do we still want to do a TEST_P?
> 
> (Should we test HTTP2 also?)

Oops, sorry I didn't catch this.

Turns out |spdy_version_| test class member here was a joke, the
SettingsFlagsAndId methods that this class exercise do not care about the
version.  So no need to test HTTP/2, it's indentical.

What is "opt mode" (in the comment)?  What does this test actually do anyway? 
Does it really test the API or an implementation detail?

https://codereview.chromium.org/1561203003/diff/1/net/spdy/spdy_test_utils.cc
File net/spdy/spdy_test_utils.cc (right):

https://codereview.chromium.org/1561203003/diff/1/net/spdy/spdy_test_utils.cc...
net/spdy/spdy_test_utils.cc:112: // The length field in SPDY 2 is a 24-bit (3B)
integer starting at
On 2016/01/07 22:09:15, Ryan Hamilton wrote:
> s/2/3/ ?

Oops.

[Ryan Hamilton, 2016-01-08 20:53:06]

lgtm

https://codereview.chromium.org/1561203003/diff/1/net/spdy/spdy_protocol_test.cc
File net/spdy/spdy_protocol_test.cc (right):

https://codereview.chromium.org/1561203003/diff/1/net/spdy/spdy_protocol_test...
net/spdy/spdy_protocol_test.cc:36: INSTANTIATE_TEST_CASE_P(SpdyProtocolTests,
On 2016/01/08 18:58:25, Bence wrote:
> On 2016/01/07 22:09:15, Ryan Hamilton wrote:
> > If we're just doing 1 version, do we still want to do a TEST_P?
> > 
> > (Should we test HTTP2 also?)
> 
> Oops, sorry I didn't catch this.
> 
> Turns out |spdy_version_| test class member here was a joke, the
> SettingsFlagsAndId methods that this class exercise do not care about the
> version.  So no need to test HTTP/2, it's indentical.
> 
> What is "opt mode" (in the comment)?  What does this test actually do anyway? 
> Does it really test the API or an implementation detail?

opt mode == !debug mode. Which is to say, when DCHECK (and friends) are not
enabled.

[Bence, 2016-01-08 21:50:18]

The CQ bit was checked by bnc@chromium.org

[commit-bot: I haz the power, 2016-01-08 21:52:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1561203003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1561203003/20001

[commit-bot: I haz the power, 2016-01-08 23:48:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-08 23:49:26]

Description was changed from

==========
Remove SPDY/2 code.

SPDY/2 code path has been unused for a long time, this CL actually removes it.

Note that there have been two comparisons between an enum SpdyMajorVersion value
and an interger literal: one in SpdyFramer::WriteHeaderBlockToZ(), and one in
spdy_http_utils.cc::SpdyHeadersToHttpResponse().  Changing enum SpdyMajorVersion
member values lead to errors.  However, removing SPDY/2 made these comparisons
mute (they were both |version < SPDY3|), so they are removed instead of fixed.

This CL lands server change 111503966 by alyssar.

BUG=431299, 488484
==========

to

==========
Remove SPDY/2 code.

SPDY/2 code path has been unused for a long time, this CL actually removes it.

Note that there have been two comparisons between an enum SpdyMajorVersion value
and an interger literal: one in SpdyFramer::WriteHeaderBlockToZ(), and one in
spdy_http_utils.cc::SpdyHeadersToHttpResponse().  Changing enum SpdyMajorVersion
member values lead to errors.  However, removing SPDY/2 made these comparisons
mute (they were both |version < SPDY3|), so they are removed instead of fixed.

This CL lands server change 111503966 by alyssar.

BUG=431299, 488484

Committed: https://crrev.com/05808ff4705c00acc1d0a2683a0ed657db4e4abf
Cr-Commit-Position: refs/heads/master@{#368459}
==========

[commit-bot: I haz the power, 2016-01-08 23:49:27]

Patchset 2 (id:??) landed as
https://crrev.com/05808ff4705c00acc1d0a2683a0ed657db4e4abf
Cr-Commit-Position: refs/heads/master@{#368459}