Remove SPDY/2 code.

net/http/http_response_info.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_response_info.h"
 
 #include "base/logging.h"
 #include "base/pickle.h"
 #include "base/time/time.h"
 #include "net/base/auth.h"
@@ skipping 371 matching lines @@
   if (connection_info != CONNECTION_INFO_UNKNOWN)
     pickle->WriteInt(static_cast<int>(connection_info));
 
   if (ssl_info.is_valid() && ssl_info.key_exchange_info != 0)
     pickle->WriteInt(ssl_info.key_exchange_info);
 }
 
 HttpResponseInfo::ConnectionInfo HttpResponseInfo::ConnectionInfoFromNextProto(
     NextProto next_proto) {
   switch (next_proto) {
-    case kProtoDeprecatedSPDY2:
-      return CONNECTION_INFO_DEPRECATED_SPDY2;
     case kProtoSPDY3:
     case kProtoSPDY31:
       return CONNECTION_INFO_SPDY3;
     case kProtoHTTP2:
       return CONNECTION_INFO_HTTP2;
     case kProtoQUIC1SPDY3:
       return CONNECTION_INFO_QUIC1_SPDY3;
 
     case kProtoUnknown:
     case kProtoHTTP11:
       break;
   }
 
   NOTREACHED();
   return CONNECTION_INFO_UNKNOWN;
 }
 
 // static
 std::string HttpResponseInfo::ConnectionInfoToString(
     ConnectionInfo connection_info) {
   switch (connection_info) {
     case CONNECTION_INFO_UNKNOWN:
       return "unknown";
     case CONNECTION_INFO_HTTP1:
       return "http/1";
     case CONNECTION_INFO_DEPRECATED_SPDY2:
-      return "spdy/2";
+      NOTREACHED();
+      return "";

[Ryan Hamilton, 2016/01/07 22:09:15]

Can we nuke this old value, or is it persisted somewhere?

[Bence, 2016/01/08 18:58:25]

Yes, we can nuke this.  However, in that case, I should probably reword the
comment above the enum:
https://code.google.com/p/chromium/codesearch#chromium/src/net/http/http_resp...

So how about a follow-up CL?

     case CONNECTION_INFO_SPDY3:
       return "spdy/3";
     // Since ConnectionInfo is persisted to disk, deprecated values have to be
     // handled. Note that h2-14 and h2-15 are essentially wire compatible with
     // h2.
     // Intentional fallthrough.
     case CONNECTION_INFO_HTTP2_14:
     case CONNECTION_INFO_HTTP2_15:
     case CONNECTION_INFO_HTTP2:
       return "h2";
     case CONNECTION_INFO_QUIC1_SPDY3:
       return "quic/1+spdy/3";
     case NUM_OF_CONNECTION_INFOS:
       break;
   }
   NOTREACHED();
   return "";
 }
 
 }  // namespace net