Issue 1561093002: Merge to XFA: Change CPDF_SyntaxParser::GetNextWord() to not pass by non-const ref.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1561093002: Merge to XFA: Change CPDF_SyntaxParser::GetNextWord() to not pass by non-const ref. (Closed)

Created:
4 years, 11 months ago by Lei Zhang

Modified:
4 years, 11 months ago

Reviewers:
Wei Li

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Change CPDF_SyntaxParser::GetNextWord() to not pass by non-const ref. Change the internal version to GetNextWordInternal(). TBR=weili@chromium.org Review URL: https://codereview.chromium.org/1558083002 . (cherry picked from commit 61197421793e24add7a250d3f15ab83dc75f80c6) Committed: https://pdfium.googlesource.com/pdfium/+/ec32127b105fc1ff74842dc939cb6fa7d23430b0

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+85 lines, -85 lines)			Patch
M	core/include/fpdfapi/fpdf_parser.h	View	3 chunks	+2 lines, -4 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_parser/fpdf_parser_fdf.cpp	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp	View	32 chunks	+78 lines, -76 lines	0 comments	Download

Total messages: 3 (1 generated)

Lei Zhang

4 years, 11 months ago (2016-01-06 09:52:59 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ec32127b105fc1ff74842dc939cb6fa7d23430b0 (presubmit successful).