Change CPDF_SyntaxParser::GetNextWord() to not pass by non-const ref.

Change CPDF_SyntaxParser::GetNextWord() to not pass by non-const ref.

Change the internal version to GetNextWordInternal().

R=weili@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/61197421793e24add7a250d3f15ab83dc75f80c6

[Lei Zhang, 2016-01-05 01:55:00]

thestig@chromium.org changed reviewers:
+ weili@chromium.org

[Lei Zhang, 2016-01-05 01:55:00]

This will conflict with https://codereview.chromium.org/1549103002/ but I'll
resolve that when landing.

[Wei Li, 2016-01-05 03:34:17]

Good overall.

https://codereview.chromium.org/1558083002/diff/1/core/src/fpdfapi/fpdf_parse...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp (right):

https://codereview.chromium.org/1558083002/diff/1/core/src/fpdfapi/fpdf_parse...
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp:1774: bool
CPDF_SyntaxParser::GetNextWordInternal() {
Consider using the similar prototype as GetNextWord by passing bIsNumber in?
This function and GetNextWord() will look simpler. Otherwise, consider writing a
comment in .h file.

[Lei Zhang, 2016-01-06 01:19:22]

https://codereview.chromium.org/1558083002/diff/1/core/src/fpdfapi/fpdf_parse...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp (right):

https://codereview.chromium.org/1558083002/diff/1/core/src/fpdfapi/fpdf_parse...
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp:1774: bool
CPDF_SyntaxParser::GetNextWordInternal() {
On 2016/01/05 03:34:17, Wei Li wrote:
> Consider using the similar prototype as GetNextWord by passing bIsNumber in?
> This function and GetNextWord() will look simpler. Otherwise, consider writing
a
> comment in .h file.

Sure.

[Wei Li, 2016-01-06 03:53:11]

lgtm

[Lei Zhang, 2016-01-06 09:46:34]

Description was changed from

==========
Change CPDF_SyntaxParser::GetNextWord() to not pass by non-const ref.

Change the internal version to GetNextWordInternal().
==========

to

==========
Change CPDF_SyntaxParser::GetNextWord() to not pass by non-const ref.

Change the internal version to GetNextWordInternal().

R=weili@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/61197421793e24add7a250d3f15ab83dc75f...
==========

[Lei Zhang, 2016-01-06 09:46:35]

Committed patchset #5 (id:80001) manually as
61197421793e24add7a250d3f15ab83dc75f80c6 (presubmit successful).