Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 1561013002: Revert "Mark pdfium chromium_code." (Closed)

Created:
4 years, 11 months ago by Nico
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Mark pdfium chromium_code." This reverts most of https://codereview.chromium.org/1557923004/ Doesn't build on the chromeos bots yet. BUG=pdfium:29 TBR=thestig Committed: https://pdfium.googlesource.com/pdfium/+/e093833b7a2d7a4991ca756ff88e7cda0fcc6e4d

Patch Set 1 #

Patch Set 2 : actually #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M pdfium.gyp View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
Nico
4 years, 11 months ago (2016-01-06 01:50:18 UTC) #3
Nico
Committed patchset #2 (id:20001) manually as e093833b7a2d7a4991ca756ff88e7cda0fcc6e4d (presubmit successful).
4 years, 11 months ago (2016-01-06 01:50:47 UTC) #6
Lei Zhang
4 years, 11 months ago (2016-01-06 01:57:22 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698