Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/runtime/runtime-array.cc

Issue 1560763002: Add Array support for @@species and subclassing (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Some fixes Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/objects.cc ('K') | « src/runtime/runtime.h ('k') | test/mjsunit/harmony/array-species.js » ('j') | test/mjsunit/harmony/array-species.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/runtime/runtime-array.cc
diff --git a/src/runtime/runtime-array.cc b/src/runtime/runtime-array.cc
index a24345ec33ee39bbd9753618a711e6108fed4a7b..50aa5eef76e8412e2d3353658a4d5eee99367f5b 100644
--- a/src/runtime/runtime-array.cc
+++ b/src/runtime/runtime-array.cc
@@ -487,5 +487,19 @@ RUNTIME_FUNCTION(Runtime_FastOneByteArrayJoin) {
// to a slow path.
return isolate->heap()->undefined_value();
}
+
+
+RUNTIME_FUNCTION(Runtime_ArraySpeciesConstructor) {
+ HandleScope scope(isolate);
+
adamk 2016/01/06 00:10:12 No blank line here.
Dan Ehrenberg 2016/01/07 00:42:58 Fixed
+ DCHECK(args.length() == 1);
+ CONVERT_ARG_HANDLE_CHECKED(Object, originalArray, 0);
adamk 2016/01/06 00:10:12 original_array
Dan Ehrenberg 2016/01/07 00:42:58 Fixed
+ Handle<Object> constructor;
+ ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
+ isolate, constructor,
+ Object::ArraySpeciesConstructor(isolate, originalArray));
+ return *constructor;
+}
+
} // namespace internal
} // namespace v8
« src/objects.cc ('K') | « src/runtime/runtime.h ('k') | test/mjsunit/harmony/array-species.js » ('j') | test/mjsunit/harmony/array-species.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698