Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: src/runtime/runtime-array.cc

Issue 1560763002: Add Array support for @@species and subclassing (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Some fixes Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/runtime/runtime-utils.h" 5 #include "src/runtime/runtime-utils.h"
6 6
7 #include "src/arguments.h" 7 #include "src/arguments.h"
8 #include "src/conversions-inl.h" 8 #include "src/conversions-inl.h"
9 #include "src/elements.h" 9 #include "src/elements.h"
10 #include "src/factory.h" 10 #include "src/factory.h"
(...skipping 469 matching lines...) Expand 10 before | Expand all | Expand 10 after
480 } 480 }
481 481
482 482
483 RUNTIME_FUNCTION(Runtime_FastOneByteArrayJoin) { 483 RUNTIME_FUNCTION(Runtime_FastOneByteArrayJoin) {
484 SealHandleScope shs(isolate); 484 SealHandleScope shs(isolate);
485 DCHECK(args.length() == 2); 485 DCHECK(args.length() == 2);
486 // Returning undefined means that this fast path fails and one has to resort 486 // Returning undefined means that this fast path fails and one has to resort
487 // to a slow path. 487 // to a slow path.
488 return isolate->heap()->undefined_value(); 488 return isolate->heap()->undefined_value();
489 } 489 }
490
491
492 RUNTIME_FUNCTION(Runtime_ArraySpeciesConstructor) {
493 HandleScope scope(isolate);
494
adamk 2016/01/06 00:10:12 No blank line here.
Dan Ehrenberg 2016/01/07 00:42:58 Fixed
495 DCHECK(args.length() == 1);
496 CONVERT_ARG_HANDLE_CHECKED(Object, originalArray, 0);
adamk 2016/01/06 00:10:12 original_array
Dan Ehrenberg 2016/01/07 00:42:58 Fixed
497 Handle<Object> constructor;
498 ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
499 isolate, constructor,
500 Object::ArraySpeciesConstructor(isolate, originalArray));
501 return *constructor;
502 }
503
490 } // namespace internal 504 } // namespace internal
491 } // namespace v8 505 } // namespace v8
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698