[Cronet] Attempt to get Cronet javadocs building on newer Javadoc doclets

[Cronet] Get Cronet javadocs building with Javadoc doclet 1.8

Some newer machines have this doclet and it's more strict
about certain things, like having every javadocs for every
parameter and every return value.  Try as I might, it also
doesn't seem to be able to @link to subclass constructors,
so I had to simplify a couple links to these also.

BUG=573255
Committed: https://crrev.com/2cd6608272e8216ea1111b79260daf67647e1915
Cr-Commit-Position: refs/heads/master@{#372925}

[pauljensen, 2016-01-30 03:16:24]

Description was changed from

==========
[Cronet] Attempt to get Cronet javadocs building on newer Javadoc doclets

BUG=573255
==========

to

==========
[Cronet] Get Cronet javadocs building with Javadoc doclet 1.8

Some newer machines have this doclet and it's more strict
about certain things, like having every javadocs for every
parameter and every return value.  Try as I might, it also
doesn't seem to be able to @link to subclass constructors,
so I had to simplify a couple links to these also.

BUG=573255
==========

[pauljensen, 2016-01-30 03:16:25]

pauljensen@chromium.org changed reviewers:
+ mef@chromium.org

[pauljensen, 2016-01-30 03:16:35]

Misha, PTAL.

[mef, 2016-02-01 16:30:10]

https://codereview.chromium.org/1560713003/diff/20001/components/cronet/andro...
File components/cronet/android/api/src/org/chromium/net/BidirectionalStream.java
(right):

https://codereview.chromium.org/1560713003/diff/20001/components/cronet/andro...
components/cronet/android/api/src/org/chromium/net/BidirectionalStream.java:311:
* BidirectionalStream.Builder}'s constructor. Should only be called once.
I think there is a bug in 1.8, which is fixed in 1.9. Andrei has suggested a
change (BidirectionalStream.Builder#Builder) that fixed android studio, but
broke the bot...

https://codereview.chromium.org/1560713003/diff/20001/components/cronet/andro...
File components/cronet/android/api/src/org/chromium/net/CronetEngine.java
(right):

https://codereview.chromium.org/1560713003/diff/20001/components/cronet/andro...
components/cronet/android/api/src/org/chromium/net/CronetEngine.java:127: *
@param userAgent the User-Agent string to use for all requests.
Should we mention that explicitly-set User-Agent header overrides this?

https://codereview.chromium.org/1560713003/diff/20001/components/cronet/andro...
components/cronet/android/api/src/org/chromium/net/CronetEngine.java:164: * Sets
whether falling back to implementation based on system's
Actually this comment is wrong. If enableLegacyMode is true, then CronetEngine
is using java implementation without even attempting to use native stack. If it
is false (by default), then it will try to use native stack, and will fallback
to java engine if that fails.

https://codereview.chromium.org/1560713003/diff/20001/components/cronet/andro...
components/cronet/android/api/src/org/chromium/net/CronetEngine.java:531: *
@param mockCertVerifier pointer to native MockCertVerifier.
I suppose we can't add link because it is not in cronet_api jar, but maybe
mention MockCertVerifier.createMockCertVerifier?

https://codereview.chromium.org/1560713003/diff/20001/components/cronet/andro...
File components/cronet/android/api/src/org/chromium/net/UrlRequest.java (right):

https://codereview.chromium.org/1560713003/diff/20001/components/cronet/andro...
components/cronet/android/api/src/org/chromium/net/UrlRequest.java:478: * @param
loadState a static int LoadState to convert.
"a static int" seems unneeded.

[mef, 2016-02-01 22:06:56]

https://codereview.chromium.org/1560713003/diff/20001/components/cronet/andro...
File components/cronet/android/api/src/org/chromium/net/BidirectionalStream.java
(right):

https://codereview.chromium.org/1560713003/diff/20001/components/cronet/andro...
components/cronet/android/api/src/org/chromium/net/BidirectionalStream.java:311:
* BidirectionalStream.Builder}'s constructor. Should only be called once.
On 2016/02/01 16:30:10, mef wrote:
> I think there is a bug in 1.8, which is fixed in 1.9. Andrei has suggested a
> change (BidirectionalStream.Builder#Builder) that fixed android studio, but
> broke the bot...

See https://bugs.openjdk.java.net/browse/JDK-8031625

[pauljensen, 2016-02-02 01:42:43]

PTAL.

https://codereview.chromium.org/1560713003/diff/20001/components/cronet/andro...
File components/cronet/android/api/src/org/chromium/net/BidirectionalStream.java
(right):

https://codereview.chromium.org/1560713003/diff/20001/components/cronet/andro...
components/cronet/android/api/src/org/chromium/net/BidirectionalStream.java:311:
* BidirectionalStream.Builder}'s constructor. Should only be called once.
On 2016/02/01 22:06:56, mef wrote:
> On 2016/02/01 16:30:10, mef wrote:
> > I think there is a bug in 1.8, which is fixed in 1.9. Andrei has suggested a
> > change (BidirectionalStream.Builder#Builder) that fixed android studio, but
> > broke the bot...
> 
> See https://bugs.openjdk.java.net/browse/JDK-8031625

Acknowledged.  I think we still need this change as 1.8 doclet may be used to
build Cronet for a while.

https://codereview.chromium.org/1560713003/diff/20001/components/cronet/andro...
File components/cronet/android/api/src/org/chromium/net/CronetEngine.java
(right):

https://codereview.chromium.org/1560713003/diff/20001/components/cronet/andro...
components/cronet/android/api/src/org/chromium/net/CronetEngine.java:127: *
@param userAgent the User-Agent string to use for all requests.
On 2016/02/01 16:30:10, mef wrote:
> Should we mention that explicitly-set User-Agent header overrides this?

Done.

https://codereview.chromium.org/1560713003/diff/20001/components/cronet/andro...
components/cronet/android/api/src/org/chromium/net/CronetEngine.java:164: * Sets
whether falling back to implementation based on system's
On 2016/02/01 16:30:10, mef wrote:
> Actually this comment is wrong. If enableLegacyMode is true, then CronetEngine
> is using java implementation without even attempting to use native stack. If
it
> is false (by default), then it will try to use native stack, and will fallback
> to java engine if that fails.

Done.

https://codereview.chromium.org/1560713003/diff/20001/components/cronet/andro...
components/cronet/android/api/src/org/chromium/net/CronetEngine.java:531: *
@param mockCertVerifier pointer to native MockCertVerifier.
On 2016/02/01 16:30:10, mef wrote:
> I suppose we can't add link because it is not in cronet_api jar, but maybe
> mention MockCertVerifier.createMockCertVerifier?

Done.

https://codereview.chromium.org/1560713003/diff/20001/components/cronet/andro...
File components/cronet/android/api/src/org/chromium/net/UrlRequest.java (right):

https://codereview.chromium.org/1560713003/diff/20001/components/cronet/andro...
components/cronet/android/api/src/org/chromium/net/UrlRequest.java:478: * @param
loadState a static int LoadState to convert.
On 2016/02/01 16:30:10, mef wrote:
> "a static int" seems unneeded.

Done.

[mef, 2016-02-02 08:02:17]

lgtm

https://codereview.chromium.org/1560713003/diff/20001/components/cronet/andro...
File components/cronet/android/api/src/org/chromium/net/BidirectionalStream.java
(right):

https://codereview.chromium.org/1560713003/diff/20001/components/cronet/andro...
components/cronet/android/api/src/org/chromium/net/BidirectionalStream.java:311:
* BidirectionalStream.Builder}'s constructor. Should only be called once.
On 2016/02/02 01:42:43, pauljensen wrote:
> On 2016/02/01 22:06:56, mef wrote:
> > On 2016/02/01 16:30:10, mef wrote:
> > > I think there is a bug in 1.8, which is fixed in 1.9. Andrei has suggested
a
> > > change (BidirectionalStream.Builder#Builder) that fixed android studio,
but
> > > broke the bot...
> > 
> > See https://bugs.openjdk.java.net/browse/JDK-8031625
> 
> Acknowledged.  I think we still need this change as 1.8 doclet may be used to
> build Cronet for a while.

Yep, my comment was mostly FYI.

[pauljensen, 2016-02-02 11:19:44]

The CQ bit was checked by pauljensen@chromium.org

[commit-bot: I haz the power, 2016-02-02 11:20:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1560713003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1560713003/60001

[commit-bot: I haz the power, 2016-02-02 11:40:48]

Description was changed from

==========
[Cronet] Get Cronet javadocs building with Javadoc doclet 1.8

Some newer machines have this doclet and it's more strict
about certain things, like having every javadocs for every
parameter and every return value.  Try as I might, it also
doesn't seem to be able to @link to subclass constructors,
so I had to simplify a couple links to these also.

BUG=573255
==========

to

==========
[Cronet] Get Cronet javadocs building with Javadoc doclet 1.8

Some newer machines have this doclet and it's more strict
about certain things, like having every javadocs for every
parameter and every return value.  Try as I might, it also
doesn't seem to be able to @link to subclass constructors,
so I had to simplify a couple links to these also.

BUG=573255
==========

[commit-bot: I haz the power, 2016-02-02 11:40:52]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-02-02 11:42:23]

Description was changed from

==========
[Cronet] Get Cronet javadocs building with Javadoc doclet 1.8

Some newer machines have this doclet and it's more strict
about certain things, like having every javadocs for every
parameter and every return value.  Try as I might, it also
doesn't seem to be able to @link to subclass constructors,
so I had to simplify a couple links to these also.

BUG=573255
==========

to

==========
[Cronet] Get Cronet javadocs building with Javadoc doclet 1.8

Some newer machines have this doclet and it's more strict
about certain things, like having every javadocs for every
parameter and every return value.  Try as I might, it also
doesn't seem to be able to @link to subclass constructors,
so I had to simplify a couple links to these also.

BUG=573255

Committed: https://crrev.com/2cd6608272e8216ea1111b79260daf67647e1915
Cr-Commit-Position: refs/heads/master@{#372925}
==========

[commit-bot: I haz the power, 2016-02-02 11:42:24]

Patchset 4 (id:??) landed as
https://crrev.com/2cd6608272e8216ea1111b79260daf67647e1915
Cr-Commit-Position: refs/heads/master@{#372925}