Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1459)

Unified Diff: components/cronet/android/api/src/org/chromium/net/UrlRequest.java

Issue 1560713003: [Cronet] Attempt to get Cronet javadocs building on newer Javadoc doclets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address Misha's comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/api/src/org/chromium/net/UrlRequest.java
diff --git a/components/cronet/android/api/src/org/chromium/net/UrlRequest.java b/components/cronet/android/api/src/org/chromium/net/UrlRequest.java
index d82488cd6033923cf6f5e0494e330a6c1b84e5ba..0f046e7e0d96e98cf38cf40c6c20b0afe395c887 100644
--- a/components/cronet/android/api/src/org/chromium/net/UrlRequest.java
+++ b/components/cronet/android/api/src/org/chromium/net/UrlRequest.java
@@ -256,8 +256,8 @@ public interface UrlRequest {
/**
* Users of Cronet extend this class to receive callbacks indicating the
* progress of a {@link UrlRequest} being processed. An instance of this class
- * is passed in to {@link UrlRequest.Builder#UrlRequest.Builder UrlRequest.Builder()}
- * when constructing the {@code UrlRequest}.
+ * is passed in to {@link UrlRequest.Builder}'s constructor when
+ * constructing the {@code UrlRequest}.
* <p>
* Note: All methods will be invoked on the thread of the
* {@link java.util.concurrent.Executor} used during construction of the
@@ -277,6 +277,7 @@ public interface UrlRequest {
* @param request Request being redirected.
* @param info Response information.
* @param newLocationUrl Location where request is redirected.
+ * @throws Exception if an error occurs while processing a redirect.
*/
public abstract void onRedirectReceived(
UrlRequest request, UrlResponseInfo info, String newLocationUrl) throws Exception;
@@ -294,6 +295,7 @@ public interface UrlRequest {
*
* @param request Request that started to get response.
* @param info Response information.
+ * @throws Exception if an error occurs while processing response start.
*/
public abstract void onResponseStarted(UrlRequest request, UrlResponseInfo info)
throws Exception;
@@ -316,6 +318,7 @@ public interface UrlRequest {
* {@link UrlRequest#read UrlRequest.read()}, now containing the
* received data. The buffer's position is updated to the end of
* the received data. The buffer's limit is not changed.
+ * @throws Exception if an error occurs while processing a read completion.
*/
public abstract void onReadCompleted(
UrlRequest request, UrlResponseInfo info, ByteBuffer byteBuffer) throws Exception;
@@ -475,7 +478,9 @@ public interface UrlRequest {
private Status() {}
/**
- * Convert a {@link LoadState} static int to one of values listed above.
+ * Convert a LoadState int to one of values listed above.
+ * @param loadState a LoadState to convert.
+ * @return static int Status.
*/
@StatusValues
static int convertLoadState(int loadState) {

Powered by Google App Engine
This is Rietveld 408576698