Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1560513002: Fix some broken pkgbuild tests. (Closed)

Created:
4 years, 11 months ago by nweiz
Modified:
4 years, 11 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix some broken pkgbuild tests. This brings in the latest version of http and shelf, and stops the pkgbuild dependency override mechanism from making packages depend on the pub package. R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/6f3168ad474d5e318874c8b370b3d2cac9f52126

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M DEPS View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
nweiz
4 years, 11 months ago (2016-01-04 23:06:19 UTC) #2
Bill Hesse
lgtm
4 years, 11 months ago (2016-01-05 09:07:20 UTC) #3
nweiz
4 years, 11 months ago (2016-01-05 21:24:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6f3168ad474d5e318874c8b370b3d2cac9f52126 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698