Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 1560513002: Fix some broken pkgbuild tests. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index 66b6a1e54f36e1152f82c71a3d8d3ea439c5e9ca..533c01cb6b56da39412e76586007cb5f2d742482 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -895,6 +895,12 @@ class StandardTestSuite extends TestSuite {
var packageDirectories = {};
if (configuration['use_repository_packages']) {
packageDirectories = new Map.from(localPackageDirectories);
+
+ // Don't create a dependency override for pub, since it's an application
+ // package and it has a dependency on compiler_unsupported which isn't
+ // in the repo.
+ packageDirectories.remove('pub');
+
// Do not create an dependency override for the package itself.
if (packageDirectories.containsKey(packageName)) {
packageDirectories.remove(packageName);
@@ -1988,6 +1994,12 @@ class PkgBuildTestSuite extends TestSuite {
var packageDirectories = {};
if (!configuration['use_public_packages']) {
packageDirectories = new Map.from(localPackageDirectories);
+
+ // Don't create a dependency override for pub, since it's an
+ // application package and it has a dependency on compiler_unsupported
+ // which isn't in the repo.
+ packageDirectories.remove('pub');
+
if (packageDirectories.containsKey(packageName)) {
packageDirectories.remove(packageName);
}
« no previous file with comments | « DEPS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698