Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1560503002: Removing the code added to make chrome compile on Aura Android. (Closed)

Created:
4 years, 11 months ago by mfomitchev
Modified:
4 years, 11 months ago
Reviewers:
brettw, sky, Hadi, no sievers
CC:
chromium-reviews, Lei Zhang, tommycli, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing the code added to make chrome compile on Aura Android. BUG=NONE Committed: https://crrev.com/e599495acceac5953cb80dc76d9b50ad78412c69 Cr-Commit-Position: refs/heads/master@{#371624}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Removing aura_android.gni #

Patch Set 4 : Undo delete of aura_android.gni - will delete in a separate CL. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -191 lines) Patch
M chrome/app/generated_resources.grd View 1 3 chunks +5 lines, -5 lines 0 comments Download
D chrome/browser/media_galleries/android/mtp_device_delegate_impl_android.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M chrome/browser/media_galleries/media_folder_finder.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser_navigator_params.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser_navigator_params.cc View 1 5 chunks +5 lines, -7 lines 0 comments Download
D chrome/browser/ui/views/frame/browser_frame_android.h View 1 chunk +0 lines, -59 lines 0 comments Download
D chrome/browser/ui/views/frame/browser_frame_android.cc View 1 chunk +0 lines, -80 lines 0 comments Download
D chrome/browser/ui/views/frame/native_browser_frame_factory_android.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 22 (8 generated)
mfomitchev
PTAL
4 years, 11 months ago (2016-01-04 22:12:48 UTC) #2
Hadi
On 2016/01/04 22:12:48, mfomitchev wrote: > PTAL lgtm
4 years, 11 months ago (2016-01-05 15:55:31 UTC) #3
mfomitchev
@sievers: ping
4 years, 11 months ago (2016-01-13 00:10:52 UTC) #4
no sievers
lgtm
4 years, 11 months ago (2016-01-14 20:22:48 UTC) #5
mfomitchev
sky@chromium.org: PTAL
4 years, 11 months ago (2016-01-15 01:02:05 UTC) #7
sky
LGTM
4 years, 11 months ago (2016-01-19 16:06:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1560503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1560503002/1
4 years, 11 months ago (2016-01-20 01:49:04 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/104179) chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 11 months ago (2016-01-20 01:55:41 UTC) #12
brettw
Can you also remove build\args\aura_android.gni? In parallel I'm adding a readme to that directory, please ...
4 years, 11 months ago (2016-01-21 18:23:20 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1560503002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1560503002/60001
4 years, 11 months ago (2016-01-26 22:08:14 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 11 months ago (2016-01-26 23:01:52 UTC) #18
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/e599495acceac5953cb80dc76d9b50ad78412c69 Cr-Commit-Position: refs/heads/master@{#371624}
4 years, 11 months ago (2016-01-26 23:03:10 UTC) #20
brettw
Can you please also remove build\args\aura_android.gni?
4 years, 11 months ago (2016-01-26 23:33:12 UTC) #21
brettw
4 years, 11 months ago (2016-01-26 23:34:36 UTC) #22
Message was sent while issue was closed.
I see the other patch now, thanks!

Powered by Google App Engine
This is Rietveld 408576698