Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1560433003: dart2js cps: Fix some analyzer hints in the CPS backend. (Closed)

Created:
4 years, 11 months ago by asgerf
Modified:
4 years, 11 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Fix some analyzer hints in the CPS backend. BUG= R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/e9f211962a29deaade6c4ad21eb62d51fc934d7d

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -45 lines) Patch
M pkg/compiler/lib/src/cps_ir/bounds_checker.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 1 chunk +0 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 2 chunks +2 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 2 chunks +15 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/inline.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/insert_refinements.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/loop_effects.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/optimize_interceptors.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 6 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
asgerf
4 years, 11 months ago (2016-01-05 17:54:14 UTC) #3
sra1
lgtm https://codereview.chromium.org/1560433003/diff/1/pkg/compiler/lib/src/cps_ir/type_propagation.dart File pkg/compiler/lib/src/cps_ir/type_propagation.dart (right): https://codereview.chromium.org/1560433003/diff/1/pkg/compiler/lib/src/cps_ir/type_propagation.dart#newcode1667 pkg/compiler/lib/src/cps_ir/type_propagation.dart:1667: node = parent as dynamic; // Make analyzer ...
4 years, 11 months ago (2016-01-05 18:54:36 UTC) #4
asgerf
https://codereview.chromium.org/1560433003/diff/1/pkg/compiler/lib/src/cps_ir/type_propagation.dart File pkg/compiler/lib/src/cps_ir/type_propagation.dart (right): https://codereview.chromium.org/1560433003/diff/1/pkg/compiler/lib/src/cps_ir/type_propagation.dart#newcode1667 pkg/compiler/lib/src/cps_ir/type_propagation.dart:1667: node = parent as dynamic; // Make analyzer accept ...
4 years, 11 months ago (2016-01-05 19:01:08 UTC) #5
asgerf
4 years, 11 months ago (2016-01-05 21:41:43 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
e9f211962a29deaade6c4ad21eb62d51fc934d7d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698