Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1217)

Side by Side Diff: pkg/compiler/lib/src/cps_ir/loop_effects.dart

Issue 1560433003: dart2js cps: Fix some analyzer hints in the CPS backend. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Rebase Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 library dart2js.cps_ir.loop_effects; 1 library dart2js.cps_ir.loop_effects;
2 2
3 import 'cps_ir_nodes.dart'; 3 import 'cps_ir_nodes.dart';
4 import 'loop_hierarchy.dart'; 4 import 'loop_hierarchy.dart';
5 import 'type_mask_system.dart';
6 import '../universe/side_effects.dart'; 5 import '../universe/side_effects.dart';
7 import '../elements/elements.dart'; 6 import '../elements/elements.dart';
8 import '../world.dart'; 7 import '../world.dart';
9 8
10 /// Determines which the [SideEffects] that may occur during each loop in 9 /// Determines which the [SideEffects] that may occur during each loop in
11 /// a given function, in addition to whether the loop may change the length 10 /// a given function, in addition to whether the loop may change the length
12 /// of an indexable object. 11 /// of an indexable object.
13 /// 12 ///
14 /// TODO(asgerf): Make length a flag on [SideEffects] for better precision and 13 /// TODO(asgerf): Make length a flag on [SideEffects] for better precision and
15 /// so we don't need to special case the length in this class. 14 /// so we don't need to special case the length in this class.
(...skipping 161 matching lines...) Expand 10 before | Expand all | Expand 10 after
177 176
178 void visitYield(Yield node) { 177 void visitYield(Yield node) {
179 addAllSideEffects(); 178 addAllSideEffects();
180 } 179 }
181 180
182 void visitApplyBuiltinMethod(ApplyBuiltinMethod node) { 181 void visitApplyBuiltinMethod(ApplyBuiltinMethod node) {
183 currentLoopSideEffects.setChangesIndex(); 182 currentLoopSideEffects.setChangesIndex();
184 currentLoopChangesLength = true; // Push and pop. 183 currentLoopChangesLength = true; // Push and pop.
185 } 184 }
186 } 185 }
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/insert_refinements.dart ('k') | pkg/compiler/lib/src/cps_ir/optimize_interceptors.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698