Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 1560333002: Merge to XFA: Replace IconTree class with std::list. (Closed)

Created:
4 years, 11 months ago by Tom Sepez
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Replace IconTree class with std::list. Original Review URL: https://codereview.chromium.org/1566433003 . (cherry picked from commit cc3727f88e48f4d26a589131dc03adca4eaac301) R=thestig@chromium.org TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/6ba32d9e65ef5d40d357876f9457e228a5fab308

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -99 lines) Patch
M fpdfsdk/src/javascript/Document.h View 3 chunks +7 lines, -22 lines 0 comments Download
M fpdfsdk/src/javascript/Document.cpp View 6 chunks +12 lines, -77 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
TBR, automatic.
4 years, 11 months ago (2016-01-06 00:23:10 UTC) #1
Lei Zhang
lgtm
4 years, 11 months ago (2016-01-06 00:23:32 UTC) #2
Tom Sepez
4 years, 11 months ago (2016-01-06 00:26:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6ba32d9e65ef5d40d357876f9457e228a5fab308 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698