Replace IconTree class with std::list.

Replace IconTree class with std::list.

Remove some O(n^2) behaviour when iterating across the thing.

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/cc3727f88e48f4d26a589131dc03adca4eaac301

[Tom Sepez, 2016-01-05 22:04:11]

Description was changed from

==========
Replace IconTree class with std::list.
==========

to

==========
Replace IconTree class with std::list.

Remove some O(n^2) behaviour when iterating across the thing.
==========

[Tom Sepez, 2016-01-05 22:06:36]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-01-05 22:06:37]

Lei, containers of unique_ptrs are now allowed, and I have a need to use them.

[Lei Zhang, 2016-01-05 22:35:31]

lgtm

https://codereview.chromium.org/1566433003/diff/20001/fpdfsdk/src/javascript/...
File fpdfsdk/src/javascript/Document.cpp (right):

https://codereview.chromium.org/1566433003/diff/20001/fpdfsdk/src/javascript/...
fpdfsdk/src/javascript/Document.cpp:158: delete m_DelayData.GetAt(i);
Looks like another good candidate to convert to using a STL container.

https://codereview.chromium.org/1566433003/diff/20001/fpdfsdk/src/javascript/...
fpdfsdk/src/javascript/Document.cpp:1276:
m_IconList.push_back(std::unique_ptr<IconElement>(
Do you know if there's a std::unique_ptr equivalent to make_scoped_ptr() ?

https://codereview.chromium.org/1566433003/diff/20001/fpdfsdk/src/javascript/...
fpdfsdk/src/javascript/Document.cpp:1293: int i = 0;
Shall we implement append() / push_back() for CJS_Array instead?

https://codereview.chromium.org/1566433003/diff/20001/fpdfsdk/src/javascript/...
File fpdfsdk/src/javascript/Document.h (right):

https://codereview.chromium.org/1566433003/diff/20001/fpdfsdk/src/javascript/...
fpdfsdk/src/javascript/Document.h:43: IconElement(CFX_WideString name, Icon*
stream)
|name| -> const ref

[Tom Sepez, 2016-01-05 23:10:09]

Note that I had to restore some empty() checks to keep the JS tests consistent.

https://codereview.chromium.org/1566433003/diff/20001/fpdfsdk/src/javascript/...
File fpdfsdk/src/javascript/Document.cpp (right):

https://codereview.chromium.org/1566433003/diff/20001/fpdfsdk/src/javascript/...
fpdfsdk/src/javascript/Document.cpp:158: delete m_DelayData.GetAt(i);
On 2016/01/05 22:35:31, Lei Zhang wrote:
> Looks like another good candidate to convert to using a STL container.

Acknowledged.

https://codereview.chromium.org/1566433003/diff/20001/fpdfsdk/src/javascript/...
fpdfsdk/src/javascript/Document.cpp:1276:
m_IconList.push_back(std::unique_ptr<IconElement>(
On 2016/01/05 22:35:31, Lei Zhang wrote:
> Do you know if there's a std::unique_ptr equivalent to make_scoped_ptr() ?

C++14 will introduce make_unique(xxx), but its not quite the same. I believe
that once we get to the year 2014, we'll write:

m_IconList.push_back(std::make_unique<IconElement>(swIconName,
(Icon*)pEmbedObj));

https://codereview.chromium.org/1566433003/diff/20001/fpdfsdk/src/javascript/...
File fpdfsdk/src/javascript/Document.h (right):

https://codereview.chromium.org/1566433003/diff/20001/fpdfsdk/src/javascript/...
fpdfsdk/src/javascript/Document.h:43: IconElement(CFX_WideString name, Icon*
stream)
On 2016/01/05 22:35:31, Lei Zhang wrote:
> |name| -> const ref

Done.

[Lei Zhang, 2016-01-05 23:22:12]

On 2016/01/05 23:10:09, Tom Sepez wrote:
> Note that I had to restore some empty() checks to keep the JS tests
consistent.

Ack.

[Tom Sepez, 2016-01-06 00:20:07]

Description was changed from

==========
Replace IconTree class with std::list.

Remove some O(n^2) behaviour when iterating across the thing.
==========

to

==========
Replace IconTree class with std::list.

Remove some O(n^2) behaviour when iterating across the thing.

R=thestig@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/cc3727f88e48f4d26a589131dc03adca4eaa...
==========

[Tom Sepez, 2016-01-06 00:20:08]

Committed patchset #3 (id:40001) manually as
cc3727f88e48f4d26a589131dc03adca4eaac301 (presubmit successful).