Oilpan: Remove GarbageCollected::ref/deref

Oilpan: Remove GarbageCollected::ref/deref

Currently, if we use ref/deref in GarbageCollected objects, it will be asserted in runtime. Alternately, this CL changes it to compile error.

This is a change requested by mads.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166989

[haraken, 2014-02-10 10:49:35]

PTAL

[wibling-chromium, 2014-02-10 11:38:45]

lgtm

[haraken, 2014-02-10 11:47:43]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-02-10 11:47:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-10 11:47:53]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[tkent, 2014-02-10 14:05:34]

lgtm

[commit-bot: I haz the power, 2014-02-10 14:05:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/156033003/1

[commit-bot: I haz the power, 2014-02-10 14:05:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-10 14:05:52]

Failed to apply patch for
Source/bindings/tests/results/V8TestInterfaceGarbageCollected.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  can't find file to patch at input line 6
  Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |Index: Source/bindings/tests/results/V8TestInterfaceGarbageCollected.cpp
  |diff --git
a/Source/bindings/tests/results/V8TestInterfaceGarbageCollected.cpp
b/Source/bindings/tests/results/V8TestInterfaceGarbageCollected.cpp
  |index
282f8fee9ef8cf67fe0ce4c0ab7b4e46f2eca51f..bca431379e353e0b430beab79de2528f8654eeaa
100644
  |--- a/Source/bindings/tests/results/V8TestInterfaceGarbageCollected.cpp
  |+++ b/Source/bindings/tests/results/V8TestInterfaceGarbageCollected.cpp
  --------------------------
  No file to patch.  Skipping patch.
  1 out of 1 hunk ignored

Patch:       Source/bindings/tests/results/V8TestInterfaceGarbageCollected.cpp
Index: Source/bindings/tests/results/V8TestInterfaceGarbageCollected.cpp
diff --git a/Source/bindings/tests/results/V8TestInterfaceGarbageCollected.cpp
b/Source/bindings/tests/results/V8TestInterfaceGarbageCollected.cpp
index
282f8fee9ef8cf67fe0ce4c0ab7b4e46f2eca51f..bca431379e353e0b430beab79de2528f8654eeaa
100644
--- a/Source/bindings/tests/results/V8TestInterfaceGarbageCollected.cpp
+++ b/Source/bindings/tests/results/V8TestInterfaceGarbageCollected.cpp
@@ -218,9 +218,10 @@ v8::Handle<v8::Object>
V8TestInterfaceGarbageCollected::createWrapper(PassRefPtr
 
 void V8TestInterfaceGarbageCollected::derefObject(void* object)
 {
+#if !ENABLE(OILPAN)
     fromInternalPointer(object)->deref();
+#endif
 }
-
 template<>
 v8::Handle<v8::Value> toV8NoInline(TestInterfaceGarbageCollected* impl,
v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
 {

[haraken, 2014-02-12 06:39:03]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-02-12 06:39:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/156033003/170001

[commit-bot: I haz the power, 2014-02-12 08:29:49]

Change committed as 166989