Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: Source/bindings/scripts/code_generator_v8.pm

Issue 156033003: Oilpan: Remove GarbageCollected::ref/deref (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/tests/results/V8TestEventTarget.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/code_generator_v8.pm
diff --git a/Source/bindings/scripts/code_generator_v8.pm b/Source/bindings/scripts/code_generator_v8.pm
index 1207addbfb84546e62149957d31408972b2356ce..93b89b49e024fb333558513e1fb16dc652460e35 100644
--- a/Source/bindings/scripts/code_generator_v8.pm
+++ b/Source/bindings/scripts/code_generator_v8.pm
@@ -4887,13 +4887,16 @@ END
GenerateSpecialWrap($interface, $v8ClassName);
GenerateToV8Converters($interface, $v8ClassName);
- $implementation{nameSpaceWebCore}->add(<<END);
-void ${v8ClassName}::derefObject(void* object)
-{
- fromInternalPointer(object)->deref();
-}
-
-END
+ $implementation{nameSpaceWebCore}->add("void ${v8ClassName}::derefObject(void* object)\n");
+ $implementation{nameSpaceWebCore}->add("{\n");
+ if (IsWillBeGarbageCollectedType($interface->name)) {
+ $implementation{nameSpaceWebCore}->add("#if !ENABLE(OILPAN)\n");
+ }
+ $implementation{nameSpaceWebCore}->add(" fromInternalPointer(object)->deref();\n");
+ if (IsWillBeGarbageCollectedType($interface->name)) {
+ $implementation{nameSpaceWebCore}->add("#endif\n");
+ }
+ $implementation{nameSpaceWebCore}->add("}\n");
$implementation{nameSpaceWebCore}->add(<<END);
template<>
« no previous file with comments | « no previous file | Source/bindings/tests/results/V8TestEventTarget.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698