ui/events/event.h - Issue 1560293002: Rename KEY_ constants to avoid conflict with <linux/input.h>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/event.h

Issue 1560293002: Rename KEY_ constants to avoid conflict with <linux/input.h> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments (Wez) Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/events/event.h

diff --git a/ui/events/event.h b/ui/events/event.h

index 4ab77519f6510057e06fbe3ba4b3cb931d5f7b60..b86b8feffe4efb20da705c7281e57c40101f0a90 100644

--- a/ui/events/event.h

+++ b/ui/events/event.h

@@ -810,7 +810,7 @@ class EVENTS_EXPORT KeyEvent : public Event {

KeyboardCode key_code_;

- // DOM KeyboardEvent |code| (e.g. DomCode::KEY_A, DomCode::SPACE).

+ // DOM KeyboardEvent |code| (e.g. DomCode::US_A, DomCode::SPACE).

// http://www.w3.org/TR/DOM-Level-3-Events-code/

// This value represents the physical position in the keyboard and can be

« no previous file with comments | « ui/base/ime/chromeos/character_composer_unittest.cc ('k') | ui/events/event_unittest.cc » ('j') | no next file with comments »