Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1560033003: Do not use suid helper when using the namespace sandbox. (Closed)

Created:
4 years, 11 months ago by rickyz (no longer on Chrome)
Modified:
4 years, 11 months ago
Reviewers:
mdempsky
CC:
chromium-reviews, darin-cc_chromium.org, jam, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not use suid helper when using the namespace sandbox. After https://codereview.chromium.org/1519753002, sandboxed processes are no longer marked non-dumpable under the namespace sandbox. This means that we no longer need to use a suid binary to change oom scores for those processes. BUG=312380 Committed: https://crrev.com/baf4d84696ebd6088363888239c3aef5f5a735f7 Cr-Commit-Position: refs/heads/master@{#367671}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M content/browser/zygote_host/zygote_host_impl_linux.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
rickyz (no longer on Chrome)
4 years, 11 months ago (2016-01-05 00:16:04 UTC) #2
mdempsky
lgtm
4 years, 11 months ago (2016-01-05 22:23:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1560033003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1560033003/1
4 years, 11 months ago (2016-01-05 22:26:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-05 22:39:39 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/baf4d84696ebd6088363888239c3aef5f5a735f7 Cr-Commit-Position: refs/heads/master@{#367671}
4 years, 11 months ago (2016-01-05 22:40:37 UTC) #8
rickyz (no longer on Chrome)
4 years, 10 months ago (2016-02-05 21:14:16 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1671233002/ by rickyz@chromium.org.

The reason for reverting is: Per issue 576409, an Android kernel patch prevents
non-root users from writing oom_score_adj. Reverting this while we investigate
alternatives..

Powered by Google App Engine
This is Rietveld 408576698