Initialize the new net internals page using the passively collected log entri...

Initialize the new net internals page using the passively collected log entries.

BUG=37421
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44266

[eroman, 2010-04-09 20:04:53]

http://codereview.chromium.org/1560025/diff/11001/12005
File chrome/browser/dom_ui/net_internals_ui.cc (right):

http://codereview.chromium.org/1560025/diff/11001/12005#newcode59
chrome/browser/dom_ui/net_internals_ui.cc:59: DictionaryValue* entry_dict = new
DictionaryValue();
This is code is unchanged (simply extracted it to a function).

[willchan no longer on Chromium, 2010-04-12 04:06:34]

LGTM

http://codereview.chromium.org/1560025/diff/11001/12005
File chrome/browser/dom_ui/net_internals_ui.cc (right):

http://codereview.chromium.org/1560025/diff/11001/12005#newcode336
chrome/browser/dom_ui/net_internals_ui.cc:336:
dom_ui_->RegisterMessageCallback("getPassiveLogEntries",
these are all incorrect, parameters must line up with the first parameter

http://codereview.chromium.org/1560025/diff/11001/12005#newcode610
chrome/browser/dom_ui/net_internals_ui.cc:610:
list->Append(EntryToDictionaryValue(e.type,
Is there a reason to pass each of these individually, rather than just passing
in e?

http://codereview.chromium.org/1560025/diff/11001/12004
File chrome/browser/net/passive_log_collector.h (right):

http://codereview.chromium.org/1560025/diff/11001/12004#newcode35
chrome/browser/net/passive_log_collector.h:35:
scoped_refptr<net::NetLog::EventParameters> extra_parameters;
You should include ref_counted.h and time.h for scoped_refptr and TimeTicks.

http://codereview.chromium.org/1560025/diff/11001/12003
File chrome/browser/net/view_net_internals_job_factory.cc (right):

http://codereview.chromium.org/1560025/diff/11001/12003#newcode76
chrome/browser/net/view_net_internals_job_factory.cc:76: // They are basically
the same thing, except PassiveLogCollector has an extra
It strikes me as weird that PassiveLogCollector::Entry doesn't just have a
CapturingNetLog::Entry as a field.  It seems like we are unnecessarily
duplicating field definitions that must be kept in sync.

[eroman, 2010-04-12 16:54:21]

http://codereview.chromium.org/1560025/diff/11001/12005
File chrome/browser/dom_ui/net_internals_ui.cc (right):

http://codereview.chromium.org/1560025/diff/11001/12005#newcode336
chrome/browser/dom_ui/net_internals_ui.cc:336:
dom_ui_->RegisterMessageCallback("getPassiveLogEntries",
On 2010/04/12 04:06:35, willchan wrote:
> these are all incorrect, parameters must line up with the first parameter

Done.

http://codereview.chromium.org/1560025/diff/11001/12004
File chrome/browser/net/passive_log_collector.h (right):

http://codereview.chromium.org/1560025/diff/11001/12004#newcode35
chrome/browser/net/passive_log_collector.h:35:
scoped_refptr<net::NetLog::EventParameters> extra_parameters;
On 2010/04/12 04:06:35, willchan wrote:
> You should include ref_counted.h and time.h for scoped_refptr and TimeTicks.

Done.

http://codereview.chromium.org/1560025/diff/11001/12003
File chrome/browser/net/view_net_internals_job_factory.cc (right):

http://codereview.chromium.org/1560025/diff/11001/12003#newcode76
chrome/browser/net/view_net_internals_job_factory.cc:76: // They are basically
the same thing, except PassiveLogCollector has an extra
On 2010/04/12 04:06:35, willchan wrote:
> It strikes me as weird that PassiveLogCollector::Entry doesn't just have a
> CapturingNetLog::Entry as a field.  It seems like we are unnecessarily
> duplicating field definitions that must be kept in sync.

Note that there is no longer a CapturingNetLog::Entry.

There is only PassiveLogCollector::Entry and CapturingNetLog::Entry. 
Ultimately I think PassiveLogCollector::Entry is the only struct that deserves
to exist, but for now there are still (non-unittest) consumers of
CapturingNetLog so it needs to stick around (and for this specific instance, we
need to convert to CapturingNetLog::Entry because net_log_util requires it)