Chromium Code Reviews
Help | Chromium Project | Sign in
(198)

Issue 1560025: Initialize the new net internals page using the passively collected log entri... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years ago by eroman
Modified:
2 years, 10 months ago
Reviewers:
willchan
CC:
chromium-reviews_chromium.org, arv, darin-cc_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Initialize the new net internals page using the passively collected log entries.

BUG=37421
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44266

Patch Set 1 #

Patch Set 2 : fix const-ness #

Patch Set 3 : fix indentation #

Total comments: 8

Patch Set 4 : Address willchan's comments #

Patch Set 5 : Add missing unittest file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -75 lines) Lint Patch
M chrome/browser/dom_ui/net_internals_ui.cc View 1 2 3 8 chunks +71 lines, -34 lines 0 comments 0 errors Download
M chrome/browser/net/passive_log_collector.h View 1 2 3 8 chunks +46 lines, -13 lines 0 comments 0 errors Download
M chrome/browser/net/passive_log_collector.cc View 1 2 3 12 chunks +50 lines, -15 lines 0 comments 0 errors Download
M chrome/browser/net/passive_log_collector_unittest.cc View 2 chunks +8 lines, -6 lines 0 comments 0 errors Download
M chrome/browser/net/view_net_internals_job_factory.cc View 1 2 3 4 chunks +29 lines, -3 lines 0 comments 0 errors Download
M chrome/browser/resources/net_internals/index.html View 1 2 3 1 chunk +6 lines, -4 lines 0 comments 0 errors Download
M chrome/browser/resources/net_internals/main.js View 1 2 3 1 chunk +5 lines, -0 lines 0 comments 0 errors Download
Commit:

Messages

Total messages: 3
eroman
http://codereview.chromium.org/1560025/diff/11001/12005 File chrome/browser/dom_ui/net_internals_ui.cc (right): http://codereview.chromium.org/1560025/diff/11001/12005#newcode59 chrome/browser/dom_ui/net_internals_ui.cc:59: DictionaryValue* entry_dict = new DictionaryValue(); This is code is ...
4 years ago #1
willchan
LGTM http://codereview.chromium.org/1560025/diff/11001/12005 File chrome/browser/dom_ui/net_internals_ui.cc (right): http://codereview.chromium.org/1560025/diff/11001/12005#newcode336 chrome/browser/dom_ui/net_internals_ui.cc:336: dom_ui_->RegisterMessageCallback("getPassiveLogEntries", these are all incorrect, parameters must line ...
4 years ago #2
eroman
4 years ago #3
http://codereview.chromium.org/1560025/diff/11001/12005
File chrome/browser/dom_ui/net_internals_ui.cc (right):

http://codereview.chromium.org/1560025/diff/11001/12005#newcode336
chrome/browser/dom_ui/net_internals_ui.cc:336:
dom_ui_->RegisterMessageCallback("getPassiveLogEntries",
On 2010/04/12 04:06:35, willchan wrote:
> these are all incorrect, parameters must line up with the first parameter

Done.

http://codereview.chromium.org/1560025/diff/11001/12004
File chrome/browser/net/passive_log_collector.h (right):

http://codereview.chromium.org/1560025/diff/11001/12004#newcode35
chrome/browser/net/passive_log_collector.h:35:
scoped_refptr<net::NetLog::EventParameters> extra_parameters;
On 2010/04/12 04:06:35, willchan wrote:
> You should include ref_counted.h and time.h for scoped_refptr and TimeTicks.

Done.

http://codereview.chromium.org/1560025/diff/11001/12003
File chrome/browser/net/view_net_internals_job_factory.cc (right):

http://codereview.chromium.org/1560025/diff/11001/12003#newcode76
chrome/browser/net/view_net_internals_job_factory.cc:76: // They are basically
the same thing, except PassiveLogCollector has an extra
On 2010/04/12 04:06:35, willchan wrote:
> It strikes me as weird that PassiveLogCollector::Entry doesn't just have a
> CapturingNetLog::Entry as a field.  It seems like we are unnecessarily
> duplicating field definitions that must be kept in sync.

Note that there is no longer a CapturingNetLog::Entry.

There is only PassiveLogCollector::Entry and CapturingNetLog::Entry. 
Ultimately I think PassiveLogCollector::Entry is the only struct that deserves
to exist, but for now there are still (non-unittest) consumers of
CapturingNetLog so it needs to stick around (and for this specific instance, we
need to convert to CapturingNetLog::Entry because net_log_util requires it)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6