Use List<String> for combinators in summaries.

Use List<String> for combinators in summaries.

Now that summaries can contain List<String>, there's no need to use a
list of an intermediate data structure.

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/8991b1c58d5310ce37ccbfac461894ce85c38932

[Paul Berry, 2016-01-04 17:18:28]

paulberry@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2016-01-04 17:21:50]

LGTM

https://codereview.chromium.org/1559963002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/resynthesize.dart (right):

https://codereview.chromium.org/1559963002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/resynthesize.dart:352: .toList();
AFAIK it is List already.

[Paul Berry, 2016-01-04 18:07:51]

https://codereview.chromium.org/1559963002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/resynthesize.dart (right):

https://codereview.chromium.org/1559963002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/resynthesize.dart:352: .toList();
On 2016/01/04 17:21:50, scheglov wrote:
> AFAIK it is List already.

Right, it is.  But I want to make a copy of the list because once we move to a
binary serialization format I believe it will be a class which implements List
and holds a reference to more data than just the list.  I've added a clarifying
comment.

[Paul Berry, 2016-01-04 18:11:06]

Description was changed from

==========
Use List<String> for combinators in summaries.

Now that summaries can contain List<String>, there's no need to use a
list of an intermediate data structure.
==========

to

==========
Use List<String> for combinators in summaries.

Now that summaries can contain List<String>, there's no need to use a
list of an intermediate data structure.

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8991b1c58d5310ce37ccbfac461894ce85c38932
==========

[Paul Berry, 2016-01-04 18:11:07]

Committed patchset #1 (id:1) manually as
8991b1c58d5310ce37ccbfac461894ce85c38932 (presubmit successful).