Use List<String> for combinators in summaries.

pkg/analyzer/lib/src/summary/resynthesize.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library summary_resynthesizer;
 
 import 'package:analyzer/analyzer.dart';
 import 'package:analyzer/src/generated/element.dart';
 import 'package:analyzer/src/generated/element_handle.dart';
 import 'package:analyzer/src/generated/engine.dart';
@@ skipping 331 matching lines @@
     }
   }
 
   /**
    * Resynthesize a [NamespaceCombinator].
    */
   NamespaceCombinator buildCombinator(UnlinkedCombinator serializedCombinator) {
     if (serializedCombinator.shows.isNotEmpty) {
       ShowElementCombinatorImpl combinator = new ShowElementCombinatorImpl();
       combinator.shownNames = serializedCombinator.shows
-          .map((UnlinkedCombinatorName n) => n.name)
           .toList();

[scheglov, 2016/01/04 17:21:50]

AFAIK it is List already.

[Paul Berry, 2016/01/04 18:07:51]

Right, it is.  But I want to make a copy of the list because once we move to a
binary serialization format I believe it will be a class which implements List
and holds a reference to more data than just the list.  I've added a clarifying
comment.

       return combinator;
     } else {
       HideElementCombinatorImpl combinator = new HideElementCombinatorImpl();
       combinator.hiddenNames = serializedCombinator.hides
-          .map((UnlinkedCombinatorName n) => n.name)
           .toList();
       return combinator;
     }
   }
 
   /**
    * Resynthesize a [ConstructorElement] and place it in the given [holder].
    */
   void buildConstructor(
       UnlinkedExecutable serializedExecutable, ElementHolder holder) {
@@ skipping 595 matching lines @@
     }
     for (FunctionTypeAliasElement typeAlias in unit.functionTypeAliases) {
       elementMap[typeAlias.name] = typeAlias;
     }
     resummarizedElements[absoluteUri] = elementMap;
     unitHolder = null;
     prelinkedUnit = null;
     unlinkedUnit = null;
   }
 }