Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1406)

Issue 1559903002: linux: Build third-party code with -Wunused-result. (Closed)

Created:
4 years, 11 months ago by Nico
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

linux: Build third-party code with -Wunused-result. Part of an effort to make warning flags consistent across platforms. BUG=574077 Committed: https://crrev.com/09874b50f59f11ddd1268d6da87989ae09f07bfb Cr-Commit-Position: refs/heads/master@{#367355}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -17 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -9 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Nico
4 years, 11 months ago (2016-01-04 15:36:16 UTC) #2
Lei Zhang
lgtm
4 years, 11 months ago (2016-01-04 19:56:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1559903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1559903002/1
4 years, 11 months ago (2016-01-04 20:00:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-04 20:11:07 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-04 20:12:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/09874b50f59f11ddd1268d6da87989ae09f07bfb
Cr-Commit-Position: refs/heads/master@{#367355}

Powered by Google App Engine
This is Rietveld 408576698