Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Side by Side Diff: build/common.gypi

Issue 1559903002: linux: Build third-party code with -Wunused-result. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 3145 matching lines...) Expand 10 before | Expand all | Expand 10 after
3156 # When we don't control the compiler, don't use -Wall for 3156 # When we don't control the compiler, don't use -Wall for
3157 # third-party code either. 3157 # third-party code either.
3158 'cflags!': [ '-Wall' ], 3158 'cflags!': [ '-Wall' ],
3159 }], 3159 }],
3160 # TODO: Fix all warnings on chromeos too. 3160 # TODO: Fix all warnings on chromeos too.
3161 [ 'os_posix==1 and OS!="mac" and OS!="ios" and (clang!=1 or chromeos== 1)', { 3161 [ 'os_posix==1 and OS!="mac" and OS!="ios" and (clang!=1 or chromeos== 1)', {
3162 'cflags!': [ 3162 'cflags!': [
3163 '-Werror', 3163 '-Werror',
3164 ], 3164 ],
3165 }], 3165 }],
3166 [ 'os_posix==1 and os_bsd!=1 and OS!="mac" and OS!="android"', {
3167 'cflags': [
3168 # Don't warn about ignoring the return value from e.g. close().
3169 # This is off by default in some gccs but on by default in others.
3170 # BSD systems do not support this option, since they are usually
3171 # using gcc 4.2.1, which does not have this flag yet.
3172 '-Wno-unused-result',
3173 ],
3174 }],
3175 [ 'OS=="win"', { 3166 [ 'OS=="win"', {
3176 'defines': [ 3167 'defines': [
3177 '_CRT_SECURE_NO_DEPRECATE', 3168 '_CRT_SECURE_NO_DEPRECATE',
3178 '_CRT_NONSTDC_NO_WARNINGS', 3169 '_CRT_NONSTDC_NO_WARNINGS',
3179 '_CRT_NONSTDC_NO_DEPRECATE', 3170 '_CRT_NONSTDC_NO_DEPRECATE',
3180 '_SCL_SECURE_NO_DEPRECATE', 3171 '_SCL_SECURE_NO_DEPRECATE',
3181 ], 3172 ],
3182 'msvs_disabled_warnings': [ 3173 'msvs_disabled_warnings': [
3183 # forcing value to bool 'true' or 'false' (performance warning) 3174 # forcing value to bool 'true' or 'false' (performance warning)
3184 4800, 3175 4800,
(...skipping 3238 matching lines...) Expand 10 before | Expand all | Expand 10 after
6423 # settings in target dicts. SYMROOT is a special case, because many other 6414 # settings in target dicts. SYMROOT is a special case, because many other
6424 # Xcode variables depend on it, including variables such as 6415 # Xcode variables depend on it, including variables such as
6425 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 6416 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
6426 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 6417 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
6427 # files to appear (when present) in the UI as actual files and not red 6418 # files to appear (when present) in the UI as actual files and not red
6428 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 6419 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
6429 # and therefore SYMROOT, needs to be set at the project level. 6420 # and therefore SYMROOT, needs to be set at the project level.
6430 'SYMROOT': '<(DEPTH)/xcodebuild', 6421 'SYMROOT': '<(DEPTH)/xcodebuild',
6431 }, 6422 },
6432 } 6423 }
OLDNEW
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698