Added method to synchronize command buffers within GpuControl.

Added method to synchronize command buffers within GpuControl.

BUG=514815
Committed: https://crrev.com/293de3cbac8d35c1dd6ea0115d087a9b1a607df7
Cr-Commit-Position: refs/heads/master@{#367457}

[David Yen, 2016-01-04 23:42:54]

This CL adds a function so we can send synchronous IPCs using gpu_control. This
will ultimately reduce a flush in this CL:

https://codereview.chromium.org/1479673003/

+piman@ for general review
+sky@ for mojo review, this function is not really relevant for mojo until the
server is moved out of process.

[David Yen, 2016-01-04 23:43:12]

dyen@chromium.org changed reviewers:
+ piman@chromium.org, sky@chromium.org

[David Yen, 2016-01-04 23:43:12]

This CL adds a function so we can send synchronous IPCs using gpu_control. This
will ultimately reduce a flush in this CL:

https://codereview.chromium.org/1479673003/

+piman@ for general review
+sky@ for mojo review, this function is not really relevant for mojo until the
server is moved out of process.

[sky, 2016-01-05 00:02:04]

LGTM

[piman, 2016-01-05 00:28:38]

https://codereview.chromium.org/1559893003/diff/40001/gpu/command_buffer/clie...
File gpu/command_buffer/client/gpu_control.h (right):

https://codereview.chromium.org/1559893003/diff/40001/gpu/command_buffer/clie...
gpu/command_buffer/client/gpu_control.h:96: virtual void
SynchronizeCommandBuffer() = 0;
Sorry for the bikeshed, but I would prefer a more descriptive name (because we
have many kind of synchronization, it's really unclear from the name what it
means).

How about: EnsureWorkVisible() ? When it returns all the previously flushed work
is visible by the service.

https://codereview.chromium.org/1559893003/diff/40001/ppapi/proxy/ppapi_comma...
File ppapi/proxy/ppapi_command_buffer_proxy.cc (right):

https://codereview.chromium.org/1559893003/diff/40001/ppapi/proxy/ppapi_comma...
ppapi/proxy/ppapi_command_buffer_proxy.cc:212: // also sends a synchronous NOP
to the actual server.
Can you file a bug? I don't want this to fall between the cracks, since it could
break subtly.

[David Yen, 2016-01-05 00:47:51]

https://codereview.chromium.org/1559893003/diff/40001/gpu/command_buffer/clie...
File gpu/command_buffer/client/gpu_control.h (right):

https://codereview.chromium.org/1559893003/diff/40001/gpu/command_buffer/clie...
gpu/command_buffer/client/gpu_control.h:96: virtual void
SynchronizeCommandBuffer() = 0;
On 2016/01/05 00:28:38, piman (OOO until 2016-1-4) wrote:
> Sorry for the bikeshed, but I would prefer a more descriptive name (because we
> have many kind of synchronization, it's really unclear from the name what it
> means).
> 
> How about: EnsureWorkVisible() ? When it returns all the previously flushed
work
> is visible by the service.

Done.

https://codereview.chromium.org/1559893003/diff/40001/ppapi/proxy/ppapi_comma...
File ppapi/proxy/ppapi_command_buffer_proxy.cc (right):

https://codereview.chromium.org/1559893003/diff/40001/ppapi/proxy/ppapi_comma...
ppapi/proxy/ppapi_command_buffer_proxy.cc:212: // also sends a synchronous NOP
to the actual server.
On 2016/01/05 00:28:38, piman (OOO until 2016-1-4) wrote:
> Can you file a bug? I don't want this to fall between the cracks, since it
could
> break subtly.

Done: https://code.google.com/p/chromium/issues/detail?id=574269

[piman, 2016-01-05 01:00:07]

LGTM, thanks!

[David Yen, 2016-01-05 01:02:55]

The CQ bit was checked by dyen@chromium.org

[David Yen, 2016-01-05 01:02:55]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1559893003/#ps60001
(title: "SynchronizeCommandBuffer() -> EnsureWorkVisible()")

[commit-bot: I haz the power, 2016-01-05 01:05:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1559893003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1559893003/60001

[commit-bot: I haz the power, 2016-01-05 02:08:15]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-01-05 02:09:13]

Description was changed from

==========
Added method to synchronize command buffers within GpuControl.

BUG=514815
==========

to

==========
Added method to synchronize command buffers within GpuControl.

BUG=514815

Committed: https://crrev.com/293de3cbac8d35c1dd6ea0115d087a9b1a607df7
Cr-Commit-Position: refs/heads/master@{#367457}
==========

[commit-bot: I haz the power, 2016-01-05 02:09:13]

Patchset 4 (id:??) landed as
https://crrev.com/293de3cbac8d35c1dd6ea0115d087a9b1a607df7
Cr-Commit-Position: refs/heads/master@{#367457}