rebaseline_server: get "image size" working again

rebaseline_server: get "image size" working again

BUG=skia:2134
NOTRY=True

Committed: http://code.google.com/p/skia/source/detail?r=13343

[epoger, 2014-02-05 20:51:14]

Ready for review at patchset 1.

You can try it out at http://172.24.179.183:8888/

https://codereview.chromium.org/155973003/diff/1/gm/rebaseline_server/static/...
File gm/rebaseline_server/static/diff_viewer.js (right):

https://codereview.chromium.org/155973003/diff/1/gm/rebaseline_server/static/...
gm/rebaseline_server/static/diff_viewer.js:2: var MAGNIFIER_WIDTH_FACTOR = 0.66;
Moved the old constants into ImageController; they are now set based on
imageWidth.

https://codereview.chromium.org/155973003/diff/1/gm/rebaseline_server/static/...
gm/rebaseline_server/static/diff_viewer.js:41: scope.setImgScale(image.width,
attrs.width);
We don't require that images are scaled down by a factor of 2 anymore.  Instead,
the scale is computed such that the image fits exactly within the desired canvas
width.

https://codereview.chromium.org/155973003/diff/1/gm/rebaseline_server/static/...
gm/rebaseline_server/static/diff_viewer.js:49: attrs.$observe('src',
function(value) {
New behavor:
- Only load the images when src= changes on the img-compare element.
- Only set imgScale when EITHER src= or width= changes.
- Only set magnifyContent when type= changes.

This allows the user to change imageSize anytime, and the redraws are correct
and fast.

https://codereview.chromium.org/155973003/diff/1/gm/rebaseline_server/static/...
File gm/rebaseline_server/static/view.html (right):

https://codereview.chromium.org/155973003/diff/1/gm/rebaseline_server/static/...
gm/rebaseline_server/static/view.html:305: <td valign="bottom"
width="{{imageSize}}">
Rather than using <br> tags to make the image thumbnails line up, use
valign=bottom.  That works regardless of how many lines of text are displayed
above the image (smaller imageSize -> narrower columns -> extra line breaks!)

[rmistry, 2014-02-05 22:14:17]

Code LGTM.
I could not play with http://172.24.179.183:8888/ because over VPN it is taking
forever to load. I can though walk over to your desk tomorrow for a quick demo
(as long is it is before 10:45).

[epoger, 2014-02-05 22:19:07]

On 2014/02/05 22:14:17, rmistry wrote:
> Code LGTM.
> I could not play with http://172.24.179.183:8888/ because over VPN it is
taking
> forever to load. I can though walk over to your desk tomorrow for a quick demo
> (as long is it is before 10:45).

Strange.  I see errors on the server side, presumably from your requests... so
it's probably out-and-out FAILING, not just taking a long time.

I just restarted the server, and I can bring up this URL in <1 minute from home
via VPN:
http://172.24.179.183:8888/static/view.html#/view.html?resultsToLoad=failures...

At any rate, I'll be happy to walk through it tomorrow morning.

[epoger, 2014-02-06 15:17:02]

The CQ bit was checked by epoger@google.com

[commit-bot: I haz the power, 2014-02-06 15:17:23]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/epoger@google.com/155973003/1

[commit-bot: I haz the power, 2014-02-06 15:17:31]

Change committed as 13343