rebaseline_server: get "image size" working again

gm/rebaseline_server/static/diff_viewer.js

Index: gm/rebaseline_server/static/diff_viewer.js
diff --git a/gm/rebaseline_server/static/diff_viewer.js b/gm/rebaseline_server/static/diff_viewer.js
index cad83321fbd192e6a39914d561b8337044dad76b..3cb3a7c2cffecc82828edff30c35449ac07086e0 100644
--- a/gm/rebaseline_server/static/diff_viewer.js
+++ b/gm/rebaseline_server/static/diff_viewer.js
@@ -1,9 +1,5 @@
-var MAX_SWAP_IMG_SIZE = 200;
-var MAGNIFIER_WIDTH = 100;
-var MAGNIFIER_HEIGHT = 100;
-var MAGNIFIER_HALF_WIDTH = MAGNIFIER_WIDTH * 0.5;
-var MAGNIFIER_HALF_HEIGHT = MAGNIFIER_HEIGHT * 0.5;
-var MAGNIFIER_SCALE_FACTOR = 2.0;
+// What portion of the image width will be taken up by the magnifier.
+var MAGNIFIER_WIDTH_FACTOR = 0.66;

[epoger, 2014/02/05 20:51:14]

Moved the old constants into ImageController; they are now set based on
imageWidth.

 
 angular.module('diff_viewer', []).directive('imgCompare', function() {
   // Custom directive for comparing (3-way) images
@@ -18,9 +14,9 @@ angular.module('diff_viewer', []).directive('imgCompare', function() {
           var ctx = canvas.getContext('2d');
           var magnifyContent = false;
 
-          // When the type attribute changes, load the image and then render
+          // When the type attribute changes, set magnifyContent appropriately.
           attrs.$observe('type', function(value) {
-              switch(value) {
+              switch(attrs.type) {
                 case "differingPixelsInWhite":
                     magnifyContent = true;
                     break;
@@ -36,26 +32,25 @@ angular.module('diff_viewer', []).directive('imgCompare', function() {
                     console.log("Unknown type attribute on <img-compare>: " + value);
                     return;
               }
+          });
+
+          // Reset ImageController's scale and render the image;
+          // we need to do this whenever attrs.src or attrs.width changes.
+          scope.setScaleAndRender = function() {
+              // compute the scaled image width/height for image and canvas
+              scope.setImgScale(image.width, attrs.width);

[epoger, 2014/02/05 20:51:14]

We don't require that images are scaled down by a factor of 2 anymore.  Instead,
the scale is computed such that the image fits exactly within the desired canvas
width.

 
+              // Set canvas to correct size
+              canvas.width = image.width / scope.imgScaleDivisor;
+              canvas.height = image.height / scope.imgScaleDivisor;
+
+              scope.renderImage();
+          };
+          attrs.$observe('src', function(value) {

[epoger, 2014/02/05 20:51:14]

New behavor:
- Only load the images when src= changes on the img-compare element.
- Only set imgScale when EITHER src= or width= changes.
- Only set magnifyContent when type= changes.

This allows the user to change imageSize anytime, and the redraws are correct
and fast.

               image.src = attrs.src;
-              image.onload = function() {
-                  // compute the scaled image width/height for image and canvas
-                  var divisor = 1;
-                  // Make it so the maximum size of an image is MAX_SWAP_IMG_SIZE,
-                  // and the images are scaled down in halves.
-                  while ((image.width / divisor) > MAX_SWAP_IMG_SIZE) {
-                      divisor *= 2;
-                  }
-
-                  scope.setImgScaleFactor(1 / divisor);
-
-                  // Set canvas to correct size
-                  canvas.width = image.width * scope.imgScaleFactor;
-                  canvas.height = image.height * scope.imgScaleFactor;
-
-                  scope.renderImage();
-              }
+              image.onload = scope.setScaleAndRender;
           });
+          attrs.$observe('width', scope.setScaleAndRender);
 
           // When the magnify attribute changes, render the magnified rect at
           // the default zoom level.
@@ -70,22 +65,22 @@ angular.module('diff_viewer', []).directive('imgCompare', function() {
                   return;
               }
 
-              var magX = magCenter.x - MAGNIFIER_HALF_WIDTH;
-              var magY = magCenter.y - MAGNIFIER_HALF_HEIGHT;
+              var magX = magCenter.x - scope.magnifierHalfWidth;
+              var magY = magCenter.y - scope.magnifierHalfHeight;
 
-              var magMaxX = canvas.width - MAGNIFIER_WIDTH;
-              var magMaxY = canvas.height - MAGNIFIER_HEIGHT;
+              var magMaxX = canvas.width - scope.magnifierWidth;
+              var magMaxY = canvas.height - scope.magnifierHeight;
 
               var magRect = { x: Math.max(0, Math.min(magX, magMaxX)),
                               y: Math.max(0, Math.min(magY, magMaxY)),
-                              width: MAGNIFIER_WIDTH,
-                              height: MAGNIFIER_HEIGHT
+                              width: scope.magnifierWidth,
+                              height: scope.magnifierHeight
                             };
 
-              var imgRect = { x: (magCenter.x / scope.imgScaleFactor) - MAGNIFIER_HALF_WIDTH,
-                              y: (magCenter.y  / scope.imgScaleFactor) - MAGNIFIER_HALF_HEIGHT,
-                              width: MAGNIFIER_WIDTH,
-                              height: MAGNIFIER_HEIGHT
+              var imgRect = { x: (magCenter.x * scope.imgScaleDivisor) - scope.magnifierHalfWidth,
+                              y: (magCenter.y * scope.imgScaleDivisor) - scope.magnifierHalfHeight,
+                              width: scope.magnifierWidth,
+                              height: scope.magnifierHeight
                             };
 
               // draw the magnified image
@@ -112,8 +107,8 @@ angular.module('diff_viewer', []).directive('imgCompare', function() {
           // compute a rect (x,y,width,height) that represents the bounding box for
           // the magnification effect
           scope.computeMagnifierOutline = function(event) {
-            var scaledWidth = MAGNIFIER_WIDTH * scope.imgScaleFactor;
-            var scaledHeight = MAGNIFIER_HEIGHT * scope.imgScaleFactor;
+            var scaledWidth = scope.magnifierWidth / scope.imgScaleDivisor;
+            var scaledHeight = scope.magnifierHeight / scope.imgScaleDivisor;
             return {
               x: event.offsetX - (scaledWidth * 0.5),
               y: event.offsetY  - (scaledHeight * 0.5),
@@ -160,12 +155,16 @@ angular.module('diff_viewer', []).directive('imgCompare', function() {
 });
 
 function ImageController($scope, $http, $location, $timeout, $parse) {
-  $scope.imgScaleFactor = 1.0;
+  $scope.imgScaleDivisor = 1.0;
   $scope.magnifierOn = false;
   $scope.magnifyCenter = undefined;
 
-  $scope.setImgScaleFactor = function(scaleFactor) {
-    $scope.imgScaleFactor = scaleFactor;
+  $scope.setImgScale = function(srcImageWidth, displayWidth) {
+    $scope.imgScaleDivisor = srcImageWidth / displayWidth;
+    $scope.magnifierWidth = displayWidth * MAGNIFIER_WIDTH_FACTOR;
+    $scope.magnifierHeight = $scope.magnifierWidth;
+    $scope.magnifierHalfWidth = $scope.magnifierWidth / 2;
+    $scope.magnifierHalfHeight = $scope.magnifierHeight / 2;
   }
 
   $scope.setMagnifierState = function(magnifierOn) {
@@ -173,7 +172,6 @@ function ImageController($scope, $http, $location, $timeout, $parse) {
   }
 
   $scope.setMagnifyCenter = function(magnifyCenter) {
-      $scope.magnifyCenter = magnifyCenter;
+    $scope.magnifyCenter = magnifyCenter;
   }
 }
-