Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1559603002: Remove Pass() on Android. (Closed)

Created:
4 years, 11 months ago by dcheng
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, gavinp+memory_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Pass() on Android. Pass() is a legacy of the original C++03 move emulation implementation. New code should use std::move from <utility>. ❆(੭ु ◜◡‾)੭ु⁾☃❆ BUG=557422 R=thestig@chromium.org Committed: https://crrev.com/92469c8c4b7da052273dee1a31308663d1dd1e3d Cr-Commit-Position: refs/heads/master@{#367251}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M base/memory/scoped_ptr_unittest.cc View 1 chunk +1 line, -1 line 1 comment Download
M base/move.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (6 generated)
dcheng
Android /should/ work now. Probably.
4 years, 11 months ago (2015-12-30 22:10:18 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1559603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1559603002/1
4 years, 11 months ago (2015-12-30 22:10:35 UTC) #3
dcheng
https://codereview.chromium.org/1559603002/diff/1/base/memory/scoped_ptr_unittest.cc File base/memory/scoped_ptr_unittest.cc (right): https://codereview.chromium.org/1559603002/diff/1/base/memory/scoped_ptr_unittest.cc#newcode405 base/memory/scoped_ptr_unittest.cc:405: #if !(defined(OS_ANDROID) || (defined(OS_LINUX) && !defined(OS_CHROMEOS))) I'll simplify this ...
4 years, 11 months ago (2015-12-30 22:10:47 UTC) #4
Lei Zhang
lgtm
4 years, 11 months ago (2015-12-30 22:26:57 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_rel/builds/3161)
4 years, 11 months ago (2015-12-30 22:38:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1559603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1559603002/1
4 years, 11 months ago (2015-12-30 23:32:31 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_dbg/builds/3176)
4 years, 11 months ago (2015-12-31 00:35:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1559603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1559603002/1
4 years, 11 months ago (2015-12-31 16:18:14 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-31 17:13:38 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/92469c8c4b7da052273dee1a31308663d1dd1e3d Cr-Commit-Position: refs/heads/master@{#367251}
4 years, 11 months ago (2015-12-31 17:14:28 UTC) #16
msramek
4 years, 11 months ago (2016-01-06 10:21:57 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1564763002/ by msramek@chromium.org.

The reason for reverting is: This breaks compilation, as there are still some
callsites of Pass() left.

See Android Cronet Data Reduction Proxy Builder build #961 and onwards:
https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Dat...
.

Powered by Google App Engine
This is Rietveld 408576698