base/memory/scoped_ptr_unittest.cc - Issue 1559603002: Remove Pass() on Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/memory/scoped_ptr_unittest.cc

Issue 1559603002: Remove Pass() on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/memory/scoped_ptr_unittest.cc

diff --git a/base/memory/scoped_ptr_unittest.cc b/base/memory/scoped_ptr_unittest.cc

index 24d43c53a966feb89bb4ae5f83b9beaeb5e273d7..f0915960f7e64284befab9df1bad313ecd752d2d 100644

--- a/base/memory/scoped_ptr_unittest.cc

+++ b/base/memory/scoped_ptr_unittest.cc

@@ -402,7 +402,7 @@ TEST(ScopedPtrTest, MoveBehavior) {

EXPECT_TRUE(scoper3.get());

}

-#if !(defined(OS_LINUX) && !defined(OS_CHROMEOS))

+#if !(defined(OS_ANDROID) || (defined(OS_LINUX) && !defined(OS_CHROMEOS)))

dcheng 2015/12/30 22:10:47 I'll simplify this conditional once I get CrOS con

// Test uncaught Pass() does not have side effects, because Pass()

// is implemented by std::move().

// TODO(danakj): Remove this test case when we remove Pass().

« no previous file with comments | « no previous file | base/move.h » ('j') | no next file with comments »