[NaCl SDK] Don't include gtest/gmock in library form

[NaCl SDK] Don't include gtest/gmock in library form

These are designed to be built from source into
each project that uses them.

The change also remove gtest/gmock from the default
include path which allows different versions to be
used, for example, in webports.

A corresponding change to webports will be required:
https://codereview.chromium.org/1555913002

Fix host_vc.mk such that it uses SRC_TO_OBJ to derive
object file name (i.e. fix http://crbug/569091).

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk;tryserver.chromium.win:win_nacl_sdk
BUG=569091
Committed: https://crrev.com/b54fa117fb6e19784a5c80d06bf28073bdb1a01c
Cr-Commit-Position: refs/heads/master@{#368128}

[Sam Clegg, 2015-12-30 12:46:32]

Description was changed from

==========
[NaCl SDK] Don't include gtest/gmock in library form

These are designed to be built from source into
each project that uses them.

The change also remove gtest/gmock from the default
include path which allows different versions to be
used, for example, in webports.
==========

to

==========
[NaCl SDK] Don't include gtest/gmock in library form

These are designed to be built from source into
each project that uses them.

The change also remove gtest/gmock from the default
include path which allows different versions to be
used, for example, in webports.

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk;tryserver.chromium.win:win_nacl_sdk
==========

[Sam Clegg, 2016-01-02 17:55:14]

The CQ bit was checked by sbc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-02 17:55:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1559463002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1559463002/40001

[Sam Clegg, 2016-01-02 18:02:58]

Description was changed from

==========
[NaCl SDK] Don't include gtest/gmock in library form

These are designed to be built from source into
each project that uses them.

The change also remove gtest/gmock from the default
include path which allows different versions to be
used, for example, in webports.

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk;tryserver.chromium.win:win_nacl_sdk
==========

to

==========
[NaCl SDK] Don't include gtest/gmock in library form

These are designed to be built from source into
each project that uses them.

The change also remove gtest/gmock from the default
include path which allows different versions to be
used, for example, in webports.

A corresponding change to webports will be required:
https://codereview.chromium.org/1555913002

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk;tryserver.chromium.win:win_nacl_sdk
==========

[Sam Clegg, 2016-01-02 18:03:12]

sbc@chromium.org changed reviewers:
+ binji@chromium.org

[commit-bot: I haz the power, 2016-01-02 20:53:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-02 20:53:23]

Dry run: Try jobs failed on following builders:
  win_nacl_sdk on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_nacl_sdk/buil...)

[Sam Clegg, 2016-01-02 21:07:35]

Description was changed from

==========
[NaCl SDK] Don't include gtest/gmock in library form

These are designed to be built from source into
each project that uses them.

The change also remove gtest/gmock from the default
include path which allows different versions to be
used, for example, in webports.

A corresponding change to webports will be required:
https://codereview.chromium.org/1555913002

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk;tryserver.chromium.win:win_nacl_sdk
==========

to

==========
[NaCl SDK] Don't include gtest/gmock in library form

These are designed to be built from source into
each project that uses them.

The change also remove gtest/gmock from the default
include path which allows different versions to be
used, for example, in webports.

A corresponding change to webports will be required:
https://codereview.chromium.org/1555913002

Fix host_vc.mk such that it uses SRC_TO_OBJ to derive
object file name (i.e. fix http://crbug/569091).

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk;tryserver.chromium.win:win_nacl_sdk
BUG=569091
==========

[Sam Clegg, 2016-01-02 21:07:54]

The CQ bit was checked by sbc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-02 21:08:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1559463002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1559463002/60001

[commit-bot: I haz the power, 2016-01-02 22:18:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-02 22:18:18]

Dry run: Try jobs failed on following builders:
  win_nacl_sdk on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_nacl_sdk/buil...)

[Sam Clegg, 2016-01-04 16:36:46]

The CQ bit was checked by sbc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-04 16:37:52]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1559463002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1559463002/120001

[commit-bot: I haz the power, 2016-01-04 17:45:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-04 17:45:39]

Dry run: This issue passed the CQ dry run.

[binji, 2016-01-04 19:48:21]

lgtm

https://codereview.chromium.org/1559463002/diff/120001/native_client_sdk/src/...
File native_client_sdk/src/resources/Makefile.example.template (right):

https://codereview.chromium.org/1559463002/diff/120001/native_client_sdk/src/...
native_client_sdk/src/resources/Makefile.example.template:55: [[  source_list =
sorted(target['SOURCES'] + target.get('EXTRA_SOURCES', []))]]
looks like you don't need EXTRA_SOURCES if they're just added to the same list.
Is it for clarity?

https://codereview.chromium.org/1559463002/diff/120001/native_client_sdk/src/...
File native_client_sdk/src/tests/nacl_io_socket_test/socket_test.cc (right):

https://codereview.chromium.org/1559463002/diff/120001/native_client_sdk/src/...
native_client_sdk/src/tests/nacl_io_socket_test/socket_test.cc:18: //#include
"gmock/gmock.h"
remove

[Sam Clegg, 2016-01-05 12:29:06]

https://codereview.chromium.org/1559463002/diff/120001/native_client_sdk/src/...
File native_client_sdk/src/resources/Makefile.example.template (right):

https://codereview.chromium.org/1559463002/diff/120001/native_client_sdk/src/...
native_client_sdk/src/resources/Makefile.example.template:55: [[  source_list =
sorted(target['SOURCES'] + target.get('EXTRA_SOURCES', []))]]
On 2016/01/04 19:48:21, binji wrote:
> looks like you don't need EXTRA_SOURCES if they're just added to the same
list.
> Is it for clarity?

SOURCES are searched for and copied into the tree.  EXTRA_SOURCES are things
that should be compiled but are not part of the package.

https://codereview.chromium.org/1559463002/diff/120001/native_client_sdk/src/...
File native_client_sdk/src/tests/nacl_io_socket_test/socket_test.cc (right):

https://codereview.chromium.org/1559463002/diff/120001/native_client_sdk/src/...
native_client_sdk/src/tests/nacl_io_socket_test/socket_test.cc:18: //#include
"gmock/gmock.h"
On 2016/01/04 19:48:21, binji wrote:
> remove

Done.

[Sam Clegg, 2016-01-05 12:29:15]

The CQ bit was checked by sbc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-05 12:29:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1559463002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1559463002/140001

[commit-bot: I haz the power, 2016-01-05 15:24:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-05 15:24:56]

Dry run: This issue passed the CQ dry run.

[Sam Clegg, 2016-01-07 13:56:33]

The CQ bit was checked by sbc@chromium.org

[Sam Clegg, 2016-01-07 13:56:34]

The patchset sent to the CQ was uploaded after l-g-t-m from binji@chromium.org
Link to the patchset: https://codereview.chromium.org/1559463002/#ps140001
(title: " ")

[commit-bot: I haz the power, 2016-01-07 13:57:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1559463002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1559463002/140001

[commit-bot: I haz the power, 2016-01-07 19:47:11]

Description was changed from

==========
[NaCl SDK] Don't include gtest/gmock in library form

These are designed to be built from source into
each project that uses them.

The change also remove gtest/gmock from the default
include path which allows different versions to be
used, for example, in webports.

A corresponding change to webports will be required:
https://codereview.chromium.org/1555913002

Fix host_vc.mk such that it uses SRC_TO_OBJ to derive
object file name (i.e. fix http://crbug/569091).

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk;tryserver.chromium.win:win_nacl_sdk
BUG=569091
==========

to

==========
[NaCl SDK] Don't include gtest/gmock in library form

These are designed to be built from source into
each project that uses them.

The change also remove gtest/gmock from the default
include path which allows different versions to be
used, for example, in webports.

A corresponding change to webports will be required:
https://codereview.chromium.org/1555913002

Fix host_vc.mk such that it uses SRC_TO_OBJ to derive
object file name (i.e. fix http://crbug/569091).

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk;tryserver.chromium.win:win_nacl_sdk
BUG=569091
==========

[commit-bot: I haz the power, 2016-01-07 19:47:12]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-01-07 19:49:08]

Description was changed from

==========
[NaCl SDK] Don't include gtest/gmock in library form

These are designed to be built from source into
each project that uses them.

The change also remove gtest/gmock from the default
include path which allows different versions to be
used, for example, in webports.

A corresponding change to webports will be required:
https://codereview.chromium.org/1555913002

Fix host_vc.mk such that it uses SRC_TO_OBJ to derive
object file name (i.e. fix http://crbug/569091).

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk;tryserver.chromium.win:win_nacl_sdk
BUG=569091
==========

to

==========
[NaCl SDK] Don't include gtest/gmock in library form

These are designed to be built from source into
each project that uses them.

The change also remove gtest/gmock from the default
include path which allows different versions to be
used, for example, in webports.

A corresponding change to webports will be required:
https://codereview.chromium.org/1555913002

Fix host_vc.mk such that it uses SRC_TO_OBJ to derive
object file name (i.e. fix http://crbug/569091).

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk;tryserver.chromium.win:win_nacl_sdk
BUG=569091

Committed: https://crrev.com/b54fa117fb6e19784a5c80d06bf28073bdb1a01c
Cr-Commit-Position: refs/heads/master@{#368128}
==========

[commit-bot: I haz the power, 2016-01-07 19:49:08]

Patchset 8 (id:??) landed as
https://crrev.com/b54fa117fb6e19784a5c80d06bf28073bdb1a01c
Cr-Commit-Position: refs/heads/master@{#368128}