Build gtest from source rather than using SDK-provided version

Build gtest from source rather than using SDK-provided version

The SDK-provided pre-built version of gtest is being
removed and replaced with a source-only version which
is more in line with the recommended practice.

Update gtest revision to the same one currently used
by chrome in order to minimize any code changes.

gtest 1.8.0 is still not out but we can/should update
to that once it is.

R=binji@chromium.org

Committed: https://chromium.googlesource.com/webports/+/a94b95855d6347205766642f55448bda8e87204b

[Sam Clegg, 2016-01-04 12:08:45]

The CQ bit was checked by sbc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-04 12:08:52]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1555913002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1555913002/80001

[Sam Clegg, 2016-01-04 12:23:09]

Description was changed from

==========
Build gtest from source rather than using SDK-probided version
==========

to

==========
Build gtest from source rather than using SDK-provided version
==========

[Sam Clegg, 2016-01-04 12:23:53]

Description was changed from

==========
Build gtest from source rather than using SDK-provided version
==========

to

==========
Build gtest from source rather than using SDK-provided version

The SDK-provided pre-built version of gtest is being
removed and replaced with a source-only version which
is more in line with the recommended practice.
==========

[Sam Clegg, 2016-01-04 12:23:53]

sbc@chromium.org changed reviewers:
+ binji@chromium.org

[commit-bot: I haz the power, 2016-01-04 14:28:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-04 14:28:18]

Dry run: Try jobs failed on following builders:
  webports-linux-clang-1 on tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/webports-linux-clang-1/bu...)

[Sam Clegg, 2016-01-04 15:07:28]

The CQ bit was checked by sbc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-04 15:07:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1555913002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1555913002/100001

[commit-bot: I haz the power, 2016-01-04 17:19:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-04 17:19:30]

Dry run: Try jobs failed on following builders:
  webports-linux-glibc-1 on tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/webports-linux-glibc-1/bu...)

[binji, 2016-01-04 19:12:55]

lgtm

https://codereview.chromium.org/1555913002/diff/100001/ports/devenv/build.sh
File ports/devenv/build.sh (right):

https://codereview.chromium.org/1555913002/diff/100001/ports/devenv/build.sh#...
ports/devenv/build.sh:29: LogExecute ${CXX} ${CPPFLAGS} ${CXXFLAGS} -o
devenv_small_test.o \
what directory does this write to? It used to prefix with ${BUILD_DIR}

https://codereview.chromium.org/1555913002/diff/100001/ports/gtest/build.sh
File ports/gtest/build.sh (right):

https://codereview.chromium.org/1555913002/diff/100001/ports/gtest/build.sh#n...
ports/gtest/build.sh:5: XEXECUTABLES="
typo?

https://codereview.chromium.org/1555913002/diff/100001/ports/libyuv/nacl.patch
File ports/libyuv/nacl.patch (right):

https://codereview.chromium.org/1555913002/diff/100001/ports/libyuv/nacl.patc...
ports/libyuv/nacl.patch:15: +      include_directories(${GTEST_SRC_DIR}/include)
why is this necessary? Perhaps when gtest is built from sources normally, the
headers are placed somewhere else?

[Sam Clegg, 2016-01-05 12:41:14]

https://codereview.chromium.org/1555913002/diff/100001/ports/devenv/build.sh
File ports/devenv/build.sh (right):

https://codereview.chromium.org/1555913002/diff/100001/ports/devenv/build.sh#...
ports/devenv/build.sh:29: LogExecute ${CXX} ${CPPFLAGS} ${CXXFLAGS} -o
devenv_small_test.o \
On 2016/01/04 19:12:54, binji wrote:
> what directory does this write to? It used to prefix with ${BUILD_DIR}

The CWD in the BuildStep is BUILD_DIR so it was redundant.

https://codereview.chromium.org/1555913002/diff/100001/ports/libyuv/nacl.patch
File ports/libyuv/nacl.patch (right):

https://codereview.chromium.org/1555913002/diff/100001/ports/libyuv/nacl.patc...
ports/libyuv/nacl.patch:15: +      include_directories(${GTEST_SRC_DIR}/include)
On 2016/01/04 19:12:54, binji wrote:
> why is this necessary? Perhaps when gtest is built from sources normally, the
> headers are placed somewhere else?

No, this is just how gtest is supposed to used.  I don't think anyone else is
using this CMakeLists.txt to build the tests so it went unnoticed.  I will
upstream this.

[Sam Clegg, 2016-01-05 12:41:39]

The CQ bit was checked by sbc@chromium.org

[Sam Clegg, 2016-01-05 12:41:40]

The patchset sent to the CQ was uploaded after l-g-t-m from binji@chromium.org
Link to the patchset: https://codereview.chromium.org/1555913002/#ps120001
(title: " ")

[commit-bot: I haz the power, 2016-01-05 12:41:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1555913002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1555913002/120001

[commit-bot: I haz the power, 2016-01-05 14:54:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-05 14:54:22]

Try jobs failed on following builders:
  webports-linux-glibc-1 on tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/webports-linux-glibc-1/bu...)

[Sam Clegg, 2016-01-07 00:20:07]

The CQ bit was checked by sbc@chromium.org

[Sam Clegg, 2016-01-07 00:20:07]

The patchset sent to the CQ was uploaded after l-g-t-m from binji@chromium.org
Link to the patchset: https://codereview.chromium.org/1555913002/#ps140001
(title: " ")

[commit-bot: I haz the power, 2016-01-07 00:20:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1555913002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1555913002/140001

[Sam Clegg, 2016-01-07 00:21:14]

Description was changed from

==========
Build gtest from source rather than using SDK-provided version

The SDK-provided pre-built version of gtest is being
removed and replaced with a source-only version which
is more in line with the recommended practice.
==========

to

==========
Build gtest from source rather than using SDK-provided version

The SDK-provided pre-built version of gtest is being
removed and replaced with a source-only version which
is more in line with the recommended practice.

Update gtest revision to the same one currently used
by chrome in order to minimize any code changes.

gtest 1.8.0 is still not out but we can/should update
to that once it is.
==========

[commit-bot: I haz the power, 2016-01-07 03:52:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-07 03:52:56]

Try jobs failed on following builders:
  webports-linux-clang-2 on tryserver.nacl (JOB_FAILED,
http://build.chromium.org/p/tryserver.nacl/builders/webports-linux-clang-2/bu...)

[Sam Clegg, 2016-01-07 13:55:59]

Description was changed from

==========
Build gtest from source rather than using SDK-provided version

The SDK-provided pre-built version of gtest is being
removed and replaced with a source-only version which
is more in line with the recommended practice.

Update gtest revision to the same one currently used
by chrome in order to minimize any code changes.

gtest 1.8.0 is still not out but we can/should update
to that once it is.
==========

to

==========
Build gtest from source rather than using SDK-provided version

The SDK-provided pre-built version of gtest is being
removed and replaced with a source-only version which
is more in line with the recommended practice.

Update gtest revision to the same one currently used
by chrome in order to minimize any code changes.

gtest 1.8.0 is still not out but we can/should update
to that once it is.

R=binji@chromium.org

Committed:
https://chromium.googlesource.com/webports/+/a94b95855d6347205766642f55448bda...
==========

[Sam Clegg, 2016-01-07 13:56:01]

Committed patchset #8 (id:140001) manually as
a94b95855d6347205766642f55448bda8e87204b (presubmit successful).