Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 155944: Switch the first thread in a child process to be the main thread... (Closed)

Created:
11 years, 5 months ago by jam
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, not_the_right_glider, Nirnimesh, jam, dank, the_wrong_timurrrr, stuartmorgan, darin (slow to review), brettw, Ben Goodger (Google)
Visibility:
Public.

Description

Switch the first thread in a child process to be the main thread, and make theIO thread be the second thread. The change is needed for plugins on mac. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21355

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : sync #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -355 lines) Patch
M chrome/browser/renderer_host/browser_render_process_host.cc View 1 2 3 chunks +8 lines, -10 lines 1 comment Download
M chrome/common/child_process.h View 1 2 2 chunks +17 lines, -11 lines 0 comments Download
M chrome/common/child_process.cc View 1 2 2 chunks +15 lines, -14 lines 0 comments Download
M chrome/common/child_thread.h View 1 2 3 chunks +16 lines, -29 lines 0 comments Download
M chrome/common/child_thread.cc View 1 2 3 chunks +43 lines, -37 lines 0 comments Download
MM chrome/common/histogram_synchronizer.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/plugin/plugin_main.cc View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/plugin/plugin_thread.h View 1 2 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/plugin/plugin_thread.cc View 1 2 6 chunks +15 lines, -41 lines 0 comments Download
M chrome/renderer/mock_render_process.h View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M chrome/renderer/render_process.h View 1 2 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/renderer/render_process.cc View 1 2 4 chunks +15 lines, -36 lines 0 comments Download
M chrome/renderer/render_process_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/render_thread.h View 1 2 3 chunks +5 lines, -16 lines 0 comments Download
M chrome/renderer/render_thread.cc View 1 2 7 chunks +36 lines, -63 lines 0 comments Download
M chrome/renderer/render_thread_unittest.cc View 1 2 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/renderer/render_view.h View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/renderer/render_view.cc View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/renderer/renderer_main.cc View 1 2 3 chunks +7 lines, -2 lines 0 comments Download
M chrome/renderer/webplugin_delegate_proxy.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/utility/utility_main.cc View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/utility/utility_thread.h View 1 2 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/utility/utility_thread.cc View 1 2 1 chunk +2 lines, -11 lines 0 comments Download
M chrome/worker/worker_main.cc View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/worker/worker_thread.h View 1 2 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/worker/worker_thread.cc View 1 2 1 chunk +7 lines, -22 lines 0 comments Download
M ipc/ipc_channel_proxy.h View 2 chunks +4 lines, -0 lines 0 comments Download
M ipc/ipc_channel_proxy.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 2 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jam
The patchset diff contains the fix for the reliability failures.
11 years, 5 months ago (2009-07-22 22:00:01 UTC) #1
darin (slow to review)
OK, LGTM (good luck!)
11 years, 5 months ago (2009-07-22 22:10:18 UTC) #2
Evan Martin
11 years, 5 months ago (2009-07-27 22:01:31 UTC) #3
http://codereview.chromium.org/155944/diff/96/1055
File chrome/browser/renderer_host/browser_render_process_host.cc (right):

http://codereview.chromium.org/155944/diff/96/1055#newcode423
Line 423: options.message_loop_type = MessageLoop::TYPE_UI;
This seems to have broken --single-process on Linux, since we can only have one
UI message loop per process.  (And even in multi-proc, our renderers don't have
access to UI stuff, so they shouldn't be UI loops anyway.)

Powered by Google App Engine
This is Rietveld 408576698