tools/build.py - Issue 1559223003: Treat R19 is a C preserved register, fixing crashing on Linux ARM64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/build.py

Issue 1559223003: Treat R19 is a C preserved register, fixing crashing on Linux ARM64. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/build.py

diff --git a/tools/build.py b/tools/build.py

index 0c5e235c16d4b80dada3bf751bb303ae4fb2904c..dac178fbf2209ef3208965ea1bbc43daba2f415c 100755

--- a/tools/build.py

+++ b/tools/build.py

@@ -153,8 +153,10 @@ def GetToolchainPrefix(target_os, arch, options):

if arch == 'arm':

# To use a non-hf compiler, specify on the command line with --toolchain.

return (DEFAULT_ARM_CROSS_COMPILER_PATH + "/arm-linux-gnueabihf")

+ if arch == 'arm64':

+ return (DEFAULT_ARM_CROSS_COMPILER_PATH + "/aarch64-linux-gnu")

- # TODO(zra): Find default MIPS and ARM64 Linux cross-compilers.

+ # TODO(zra): Find default MIPS Linux cross-compiler.

return None