runtime/vm/stub_code_arm64.cc - Issue 1559223003: Treat R19 is a C preserved register, fixing crashing on Linux ARM64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/stub_code_arm64.cc

Issue 1559223003: Treat R19 is a C preserved register, fixing crashing on Linux ARM64. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/stub_code_arm64.cc

diff --git a/runtime/vm/stub_code_arm64.cc b/runtime/vm/stub_code_arm64.cc

index 7624fa20acb2b55281d2b66ae99b601fe33f2257..5b98fe5eff790ba760613b602222d6509a10441b 100644

--- a/runtime/vm/stub_code_arm64.cc

+++ b/runtime/vm/stub_code_arm64.cc

@@ -829,7 +829,7 @@ void StubCode::GenerateInvokeDartCodeStub(Assembler* assembler) {

__ LoadFromOffset(R6, THR, Thread::top_exit_frame_info_offset());

__ StoreToOffset(ZR, THR, Thread::top_exit_frame_info_offset());

// kExitLinkSlotFromEntryFp must be kept in sync with the code below.

- ASSERT(kExitLinkSlotFromEntryFp == -21);

+ ASSERT(kExitLinkSlotFromEntryFp == -22);

__ Push(R6);

// Load arguments descriptor array into R4, which is passed to Dart code.