Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: gpu/command_buffer/service/gl_stream_texture_image.h

Issue 1559203003: Add GLStreamTextureImage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removed shared context check and removed matrix from copier. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/gl_stream_texture_image.h
diff --git a/gpu/command_buffer/service/gl_stream_texture_image.h b/gpu/command_buffer/service/gl_stream_texture_image.h
new file mode 100644
index 0000000000000000000000000000000000000000..018d7b826c8a6c3a8c9031af957cf91f53cf734a
--- /dev/null
+++ b/gpu/command_buffer/service/gl_stream_texture_image.h
@@ -0,0 +1,33 @@
+// Copyright (c) 2016 The Chromium Authors. All rights reserved.
reveman 2016/02/19 19:15:39 nit: Remove " (c)". Just "Copyright 2016" in new f
liberato (no reviews please) 2016/02/19 19:48:11 Done.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef GPU_COMMAND_BUFFER_SERVICE_GL_STREAM_TEXTURE_IMAGE_H_
+#define GPU_COMMAND_BUFFER_SERVICE_GL_STREAM_TEXTURE_IMAGE_H_
+
+#include "ui/gl/gl_image.h"
+
+namespace gpu {
+namespace gles2 {
+
+// Specialization of GLImage that allows us to support (stream) textures
+// that supply a texture matrix.
+class GL_EXPORT GLStreamTextureImage : public gl::GLImage {
+ public:
+ GLStreamTextureImage() {}
reveman 2016/02/19 19:15:39 nit: don't think you need this if you make GetText
liberato (no reviews please) 2016/02/19 19:48:11 i thought so too, until it complained about lack o
+
+ // Get the matrix
reveman 2016/02/19 19:15:39 nit: end with "." if this is the end of a comment
liberato (no reviews please) 2016/02/19 19:48:11 Done.
+ // Copy the texture matrix for this image into |matrix|.
+ virtual void GetTextureMatrix(float matrix[16]);
reveman 2016/02/19 19:15:39 Pure virtual? ... = 0;
liberato (no reviews please) 2016/02/19 19:48:11 thanks, leftover from when i didn't want to do tha
+
+ protected:
+ virtual ~GLStreamTextureImage() {}
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(GLStreamTextureImage);
+};
+
+} // namespace gles2
+} // namespace gpu
+
+#endif // GPU_COMMAND_BUFFER_SERVICE_GL_STREAM_TEXTURE_IMAGE_H_

Powered by Google App Engine
This is Rietveld 408576698