Add GLStreamTextureImage

gpu/command_buffer/service/gl_stream_texture_image.h

+// Copyright (c) 2016 The Chromium Authors. All rights reserved.

[reveman, 2016/02/19 19:15:39]

nit: Remove " (c)". Just "Copyright 2016" in new files.

[liberato (no reviews please), 2016/02/19 19:48:11]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef GPU_COMMAND_BUFFER_SERVICE_GL_STREAM_TEXTURE_IMAGE_H_
+#define GPU_COMMAND_BUFFER_SERVICE_GL_STREAM_TEXTURE_IMAGE_H_
+
+#include "ui/gl/gl_image.h"
+
+namespace gpu {
+namespace gles2 {
+
+// Specialization of GLImage that allows us to support (stream) textures
+// that supply a texture matrix.
+class GL_EXPORT GLStreamTextureImage : public gl::GLImage {
+ public:
+  GLStreamTextureImage() {}

[reveman, 2016/02/19 19:15:39]

nit: don't think you need this if you make GetTextureMatrix pure virtual

[liberato (no reviews please), 2016/02/19 19:48:11]

i thought so too, until it complained about lack of a default constructor in
AVDACodecImage.  not sure why, but i put it back anyway.

+
+  // Get the matrix

[reveman, 2016/02/19 19:15:39]

nit: end with "." if this is the end of a comment or sentence. maybe the line
below is sufficient.

[liberato (no reviews please), 2016/02/19 19:48:11]

Done.

+  // Copy the texture matrix for this image into |matrix|.
+  virtual void GetTextureMatrix(float matrix[16]);

[reveman, 2016/02/19 19:15:39]

Pure virtual? ... = 0;

[liberato (no reviews please), 2016/02/19 19:48:11]

thanks, leftover from when i didn't want to do that on GLImage until the name
was finalized.

+
+ protected:
+  virtual ~GLStreamTextureImage() {}
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(GLStreamTextureImage);
+};
+
+}  // namespace gles2
+}  // namespace gpu
+
+#endif  // GPU_COMMAND_BUFFER_SERVICE_GL_STREAM_TEXTURE_IMAGE_H_