ui/events/keycodes/keyboard_code_conversion.cc - Issue 1559163002: Clean up event flags a bit:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/keycodes/keyboard_code_conversion.cc

Issue 1559163002: Clean up event flags a bit: (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comment Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/events/keycodes/keyboard_code_conversion.cc

diff --git a/ui/events/keycodes/keyboard_code_conversion.cc b/ui/events/keycodes/keyboard_code_conversion.cc

index f4d637b4e1534a7da1dc37a49e5d6be0d04a8993..3657abc25a44c08a9542035e1b31fe966367e05e 100644

--- a/ui/events/keycodes/keyboard_code_conversion.cc

+++ b/ui/events/keycodes/keyboard_code_conversion.cc

@@ -41,7 +41,7 @@ bool DomCodeToUsLayoutDomKey(DomCode dom_code,

if (it.dom_code == dom_code) {

int state = ((flags & EF_SHIFT_DOWN) == EF_SHIFT_DOWN);

base::char16 ch = it.character[state];

- if ((flags & EF_CAPS_LOCK_DOWN) == EF_CAPS_LOCK_DOWN) {

+ if ((flags & EF_CAPS_LOCK_ON) == EF_CAPS_LOCK_ON) {

ch |= 0x20;

if ((ch >= 'a') && (ch <= 'z'))

ch = it.character[state ^ 1];