Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3438)

Unified Diff: chrome/browser/chromeos/input_method/input_method_engine.cc

Issue 1559163002: Clean up event flags a bit: (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comment Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/input_method/input_method_engine.cc
diff --git a/chrome/browser/chromeos/input_method/input_method_engine.cc b/chrome/browser/chromeos/input_method/input_method_engine.cc
index 1f8c72beef8ab35f0dd022fe8955117e8c3cf4a5..db1ad4d6827fbafcb610b9baa245b0a62eb0bf4c 100644
--- a/chrome/browser/chromeos/input_method/input_method_engine.cc
+++ b/chrome/browser/chromeos/input_method/input_method_engine.cc
@@ -150,7 +150,7 @@ void GetExtensionKeyboardEventFromKeyEvent(
ext_event->alt_key = event.IsAltDown();
ext_event->ctrl_key = event.IsControlDown();
ext_event->shift_key = event.IsShiftDown();
- ext_event->caps_lock = event.IsCapsLockDown();
+ ext_event->caps_lock = event.IsCapsLockOn();
ext_event->key = GetKeyFromEvent(event);
}
@@ -306,7 +306,7 @@ bool InputMethodEngine::SendKeyEvents(
flags |= event.alt_key ? ui::EF_ALT_DOWN : ui::EF_NONE;
flags |= event.ctrl_key ? ui::EF_CONTROL_DOWN : ui::EF_NONE;
flags |= event.shift_key ? ui::EF_SHIFT_DOWN : ui::EF_NONE;
- flags |= event.caps_lock ? ui::EF_CAPS_LOCK_DOWN : ui::EF_NONE;
+ flags |= event.caps_lock ? ui::EF_CAPS_LOCK_ON : ui::EF_NONE;
ui::KeyEvent ui_event(
type, key_code,

Powered by Google App Engine
This is Rietveld 408576698