chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc - Issue 1559163002: Clean up event flags a bit:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc

Issue 1559163002: Clean up event flags a bit: (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comment Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc

diff --git a/chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc b/chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc

index af45182e75ee6a8b15cb3c6d72d3551274d6509f..50c28a907e21285a56508b2507ae9194e63296ce 100644

--- a/chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc

+++ b/chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc

@@ -340,10 +340,8 @@ IN_PROC_BROWSER_TEST_P(InputMethodEngineBrowserTest,

"onKeyEvent::keydown:A:KeyA:false:false:false:true";

ExtensionTestMessageListener keyevent_listener(expected_value, false);

- ui::KeyEvent key_event(ui::ET_KEY_PRESSED,

- ui::VKEY_A,

- ui::DomCode::US_A,

- ui::EF_CAPS_LOCK_DOWN);

+ ui::KeyEvent key_event(ui::ET_KEY_PRESSED, ui::VKEY_A, ui::DomCode::US_A,

+ ui::EF_CAPS_LOCK_ON);

ui::IMEEngineHandlerInterface::KeyEventDoneCallback keyevent_callback =

base::Bind(&KeyEventDoneCallback::Run, base::Unretained(&callback));

engine_handler->ProcessKeyEvent(key_event, keyevent_callback);

@@ -376,10 +374,8 @@ IN_PROC_BROWSER_TEST_P(InputMethodEngineBrowserTest,

"onKeyEvent::keydown:a:KeyA:false:false:true:true";