Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1535)

Unified Diff: chrome/browser/chromeos/events/event_rewriter.cc

Issue 1559163002: Clean up event flags a bit: (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comment Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/events/event_rewriter.cc
diff --git a/chrome/browser/chromeos/events/event_rewriter.cc b/chrome/browser/chromeos/events/event_rewriter.cc
index bf7d9a37a5ed199d2b5008cd41130a0d957d69e5..3b88fc7c7fe605f588f3167e0490ae9ecbbadc27 100644
--- a/chrome/browser/chromeos/events/event_rewriter.cc
+++ b/chrome/browser/chromeos/events/event_rewriter.cc
@@ -749,7 +749,7 @@ bool EventRewriter::RewriteModifierKeys(const ui::KeyEvent& key_event,
// XK_ISO_Level3_Shift with Mod3Mask, not XF86XK_Launch7).
case ui::DomCode::F16:
case ui::DomCode::CAPS_LOCK:
- characteristic_flag = ui::EF_CAPS_LOCK_DOWN;
+ characteristic_flag = ui::EF_CAPS_LOCK_ON;
remapped_key =
GetRemappedKey(prefs::kLanguageRemapCapsLockKeyTo, *pref_service);
break;
@@ -791,7 +791,7 @@ bool EventRewriter::RewriteModifierKeys(const ui::KeyEvent& key_event,
incoming.flags |= characteristic_flag;
characteristic_flag = remapped_key->flag;
if (remapped_key->remap_to == input_method::kCapsLockKey)
- characteristic_flag |= ui::EF_CAPS_LOCK_DOWN;
+ characteristic_flag |= ui::EF_CAPS_LOCK_ON;
state->code = RelocateModifier(
state->code, ui::KeycodeConverter::DomCodeToLocation(incoming.code));
}

Powered by Google App Engine
This is Rietveld 408576698