ash/content/keyboard_overlay/keyboard_overlay_view_unittest.cc - Issue 1559163002: Clean up event flags a bit:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/content/keyboard_overlay/keyboard_overlay_view_unittest.cc

Issue 1559163002: Clean up event flags a bit: (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comment Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/content/keyboard_overlay/keyboard_overlay_view_unittest.cc

diff --git a/ash/content/keyboard_overlay/keyboard_overlay_view_unittest.cc b/ash/content/keyboard_overlay/keyboard_overlay_view_unittest.cc

index ef5159ed79b6b03c1f11531480bb97b9202acdbb..4e129e85329071e7bada12c0a8e5409c9838e317 100644

--- a/ash/content/keyboard_overlay/keyboard_overlay_view_unittest.cc

+++ b/ash/content/keyboard_overlay/keyboard_overlay_view_unittest.cc

@@ -50,8 +50,8 @@ TEST_F(KeyboardOverlayViewTest, TestCancelingKeysWithNonModifierFlags) {

ShellContentState::GetInstance()->GetActiveBrowserContext(), &delegate,

new ui::test::TestWebContentsHandler);

- const int kNonModifierFlags = ui::EF_IS_REPEAT | ui::EF_IME_FABRICATED_KEY |

- ui::EF_NUM_LOCK_DOWN | ui::EF_IS_SYNTHESIZED;

+ const int kNonModifierFlags = ui::EF_IS_SYNTHESIZED | ui::EF_NUM_LOCK_ON |

+ ui::EF_IME_FABRICATED_KEY | ui::EF_IS_REPEAT;

std::vector<KeyboardOverlayView::KeyEventData> canceling_keys;

KeyboardOverlayView::GetCancelingKeysForTesting(&canceling_keys);